Plasma 6 compatibility

[guiodic]

Hi, is an update planned for Plasma 6?

Thank you!

[guiodic]

Plasma 6 was released today. I hope this decoration can be updated to the new DE. Thank you!

[guiodic]

Sorry, a gentle bump :)

[AntarEspadas]

I am also curious if an update is planned

[abolast]

I regret not having learned C++. C++ is too difficult.
Similarly, this tool can improve my work efficiency.

[guiodic]

I am seeing that @Zren is prioritizing widgets, I hope he has time for this decoration, much of the work I think has already been done. I really can't get by without the LIM!

[nicman23]

I am independently working on it, I just need to figure out kconfig but it is so boring as I do not use the kconfig menu, as I always just changed the source code

[guiodic]

Thank you very much! Il mar 9 apr 2024, 12:19 nicman23 ***@***.***> ha scritto:

…

I am independently working on it, I just need to figure out kconfig but it is so boring as I do not use the kconfig menu, as I always just changed the source code — Reply to this email directly, view it on GitHub <#73 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACH63BB5XZBZCG2OSND7BDY4O6E7AVCNFSM6AAAAABCFC2OXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBUGY2TGNZXGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[guiodic]

@nicman23 do you have any news? Is it possible to test the decoration?

[nicman23]

sorry guys it is a tough month, i might just upload whatever i have already done but yeah i have not worked at it at all

[guiodic]

Thank you very much! I dont care kconfig for now, default options are ok for me, I will eventually change source code. Or, if present, the values in kwinrc.

[guiodic]

@nicman23 sorry to bother you but... any news?

[nicman23]

sorry here is the wip code https://github.com/nicman23/material-decoration but still no progress since my first message

[guiodic]

thank you. I tried to build it. I receive an error on qtdbusmenu so I tried commenting the line in cmake but then I receive another error on "FindQt.cmake".
Well, I will wait...

[Anarcraft]

On my test machine I don't see a package named "Qt6" which this would parse to:
find_package(QT NAMES Qt${QT_VERSION_MAJOR})
It may be the package named "Qt6-base".

[guiodic]

On my test machine I don't see a package named "Qt6" which this would parse to: find_package(QT NAMES Qt${QT_VERSION_MAJOR}) It may be the package named "Qt6-base".

I presume "package" in cmake refers to QT internal names, not to the packages from the distribution.

[Anarcraft]

On my test machine I don't see a package named "Qt6" which this would parse to: find_package(QT NAMES Qt${QT_VERSION_MAJOR}) It may be the package named "Qt6-base".

I presume "package" in cmake refers to QT internal names, not to the packages from the distribution.

Oh, OK, I don't know much about cmake.

[guiodic]

@nicman23 sorry to bother you again ...

[nicman23]

i ll take a crack at it if i have no work today

[nicman23]

i did make it compile but it does not show up in system config. if at all possible @Zren could you take a look?

it is not buy any way ready - i have removed the configuration for now - but it should had worked (?)

just for reference it compiles with qt6 and kf6

[guiodic]

thank you. I still receive this error:

CMake Error at /usr/lib/cmake/Qt6DBus/Qt6DBusMacros.cmake:64 (qt5_add_dbus_interface):
Unknown CMake command "qt5_add_dbus_interface".
Call Stack (most recent call first):
src/libdbusmenuqt/CMakeLists.txt:24 (qt_add_dbus_interface)

[guiodic]

and if I comment the qt dbusmenu including in cmake, thei I receive this other error:
CMake Error at /usr/lib/cmake/Qt6Qml/Qt6QmlMacros.cmake:2829 (message):
qt_generate_foreign_qml_types() is only available in Qt 6.
Call Stack (most recent call first):
/usr/lib/cmake/Qt6Qml/Qt6QmlConfig.cmake:145 (include)
/usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
/usr/lib/cmake/KF6Config/KF6ConfigConfig.cmake:53 (find_dependency)
/usr/share/ECM/find-modules/FindKF6.cmake:52 (find_package)
src/CMakeLists.txt:13 (find_package)

(I'm on Manjaro unstable, it's pretty the same of arch)

[guiodic]

p.s. I use this command to build:
cmake -DCMAKE_INSTALL_PREFIX=/usr ..

[nicman23]

try cmake -DQT_MAJOR_VERSION=6 -DCMAKE_INSTALL_PREFIX=/usr ..

[guiodic]

yes, it works! thank you! but it has not shadow

[guiodic]

i tried to add this to kdecoration_materialrc

[Common]
MenuAlwaysShow=true
ShadowStrength=128

but the shadow doesn't show. Anyway the menu works

[nicman23]

what? tf, it does not work on my machine :D

E: huh the .so is installed in the wrong folder. i do not care to look into it right now, i just did a

cp src/materialdecoration.so /usr/lib/qt6/plugins/org.kde.kdecoration2/

and it worked lol

[guiodic]

@nicman23 I hope the shadows can be restored.

[nicman23]

i do not use them so probably eh maybe

[guiodic]

i do not use them so probably eh maybe

Please 🙏🙏🙏

[guiodic]

@nicman23 can you at least make some suggestions? I tried fiddling with the code but couldn't solve the shadow problem. Thank you!

@Zren some love for this bug? Thanks!

[guiodic]

Sorry again @nicman23 ...

[guiodic]

To restore shadows, in the Decoration.cc, line 567

if (!s_cachedShadow ---> if (s_cachedShadow

[guiodic]

Is there any chance of this decoration being ported to Wayland?

[nicman23]

no

[guiodic]

no

maybe @Zren ?

[nicman23]

no i mean it is currently not possible

[guiodic]

no i mean it is currently not possible

Can you explain why? Thank you!

[HerrCraziDev]

no i mean it is currently not possible

Can you explain why? Thank you!

Because Wayland sucks. It's much more restrictive than X11.

Also, any progress on this ?

[guiodic]

no i mean it is currently not possible

Can you explain why? Thank you!

Because Wayland sucks. It's much more restrictive than X11.

Also, any progress on this ?

I agree on Wayland sucks etc. but in this particular case I think there are no major problems, in fact the global menu and the menu button in the title bar work correctly (at least for QT apps, the GTK ones have a problem upstream)

[HerrCraziDev]

Damn I'll have to switch to Debian /s