Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precomputation folder name based on model name causes HunyuanVideo Lora training error #200

Closed
1 of 2 tasks
LiuXiaolong19920720 opened this issue Jan 9, 2025 · 1 comment · Fixed by #199
Closed
1 of 2 tasks

Comments

@LiuXiaolong19920720
Copy link

System Info / 系統信息

python3.10
pytorch2.5.1
cuda12.1

Information / 问题信息

  • The official example scripts / 官方的示例脚本
  • My own modified scripts / 我自己修改的脚本和任务

Reproduction / 复现过程

  1. follow https://github.com/a-r-r-o-w/finetrainers/blob/main/docs/training/hunyuan_video.md

Expected behavior / 期待表现

Model name based precomputation folder name is used when precompute latents and conditions. But the path in PrecomputedDataset keep use the old format path.

class PrecomputedDataset(Dataset):
    def __init__(self, data_root: str) -> None:
        super().__init__()

        self.data_root = Path(data_root)

        self.latents_path = self.data_root / PRECOMPUTED_DIR_NAME / PRECOMPUTED_LATENTS_DIR_NAME
        self.conditions_path = self.data_root / PRECOMPUTED_DIR_NAME / PRECOMPUTED_CONDITIONS_DIR_NAME
@a-r-r-o-w
Copy link
Owner

Yes, sorry this slipped through. This is being fixed in #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants