Message authorize

.editorconfig

@@ -8,15 +8,15 @@ root = true
 charset = utf-8
 end_of_line = lf
 indent_style = space
-indent_size = 2
+indent_size = 4
 insert_final_newline = true
 trim_trailing_whitespace = true
 max_line_length = 120
 
 # Go files follow gofmt conventions: tabs, no trailing whitespace, LF endings
 [*.go]
 indent_style = tab
-tab_width = 2
+tab_width = 4
 trim_trailing_whitespace = true
 insert_final_newline = true
 

.github/workflows/benchmarks.yml

@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        go: [1.24.7, 1.25.1]
+        go: [1.24.7, 1.25.2]
 
     steps:
       - uses: actions/checkout@v4

.github/workflows/build.yml

@@ -1,8 +1,8 @@
 name: Build
 
 on:
-  push:            # any branch
-  pull_request:    # selected PR events
+  push:
+  pull_request:
     types: [opened, synchronize, reopened, ready_for_review]
 
 concurrency:
@@ -20,11 +20,11 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        go: ${{ fromJSON( (github.ref == 'refs/heads/main' || (github.event_name == 'pull_request' && github.base_ref == 'main')) && '["1.24.7","1.25.1"]' || '["1.25.1"]' ) }}
+        go: ${{ fromJSON( (github.ref == 'refs/heads/main' || (github.event_name == 'pull_request' && github.base_ref == 'main')) && '["1.24.7","1.25.2"]' || '["1.25.2"]' ) }}
     steps:
       - uses: actions/checkout@v5
 
-      - uses: actions/setup-go@v5
+      - uses: actions/setup-go@v6
         with:
           go-version: ${{ matrix.go }}
           cache: false
@@ -57,15 +57,15 @@ jobs:
     steps:
       - uses: actions/checkout@v5
 
-      - uses: actions/setup-go@v5
+      - uses: actions/setup-go@v6
         with:
-          go-version: 1.25
+          go-version: 1.25.2
           cache: false
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v8.0.0
+        uses: golangci/golangci-lint-action@v8
         with:
-          version: v2.1
+          version: v2.5
           args: --config golangci.yml --timeout=5m ./...
 
       - name: Report
@@ -84,9 +84,9 @@ jobs:
     steps:
       - uses: actions/checkout@v5
 
-      - uses: actions/setup-go@v5
+      - uses: actions/setup-go@v6
         with:
-          go-version: 1.25.1
+          go-version: 1.25.2
           cache: false
 
       - run: mkdir -p reports
@@ -109,18 +109,21 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        go: ${{ fromJSON( (github.ref == 'refs/heads/main' || (github.event_name == 'pull_request' && github.base_ref == 'main')) && '["1.24.7","1.25.1"]' || '["1.25.1"]' ) }}
+        go: ${{ fromJSON( (github.ref == 'refs/heads/main' || (github.event_name == 'pull_request' && github.base_ref == 'main')) && '["1.24.7","1.25.2"]' || '["1.25.2"]' ) }}
     steps:
       - uses: actions/checkout@v5
 
-      - uses: actions/setup-go@v5
+      - uses: actions/setup-go@v6
         with:
           go-version: ${{ matrix.go }}
           cache: false
+
       - run: mkdir -p reports
 
       - run: go vet ./... >reports/vet
 
+      - run: cat reports/vet
+
       - name: Upload Artifacts
         uses: actions/upload-artifact@v4
         with:
@@ -139,7 +142,7 @@ jobs:
     steps:
       - uses: actions/checkout@v5
         with:
-          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+          fetch-depth: 0
 
       - name: Download All Artifacts
         uses: actions/download-artifact@v5
@@ -148,6 +151,6 @@ jobs:
           merge-multiple: true
 
       - name: SonarQube Scan
-        uses: SonarSource/sonarqube-scan-action@v5
+        uses: SonarSource/sonarqube-scan-action@v6
         env:
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

AGENTS.md

@@ -6,42 +6,55 @@
 - Tools used by Makefile: golangci-lint, staticcheck, ripgrep (rg), gci, gofumpt, golines, pkgsite, sonar-scanner
   (optional)
 
-## Build & Modules
-
-- go mod tidy — ensure deps are tidy
-- Library package; no binary build target
-
-## Test
-
-- All tests with coverage: make test (artifacts in reports/)
-- Open HTML coverage: make test-coverage
-- Run a single package: go test -v ./shared/types
-- Run a single test: go test -v ./shared/types -run '^TestDateTime$'
-- Run example tests: make test-example (or: go test -run '^Example' ./...)
-- Benchmarks: make test-benchmark (or: go test -tags=benchmark -bench=. -benchmem ./...)
-- Run a single benchmark: go test -run '^$' -bench '^BenchmarkInteger$' ./shared/types/benchmark
-
-## Lint, Vet, Format
-
-- Lint suite: make lint (golangci-lint, go vet → reports/govet.json, staticcheck → reports/staticcheck)
-- Format: make format (gci write; gofumpt; golines; gofmt) — run before committing
-
-## Code Style Guidelines
-
-- Imports: managed by gci; group stdlib, module (github.com/aasanchez/ocpp16messages), then others; no unused imports
-- Formatting: gofumpt + golines; keep lines concise; run make format to enforce
-- Types: prefer precise types in shared/types; time parsing/formatting uses RFC3339/RFC3339Nano (see DateTime)
-- Naming: exported identifiers use PascalCase; keep acronyms like ID in caps (revive var-naming allows ID)
-- Errors: do not panic in library code; wrap with fmt.Errorf("context: %w", err); provide actionable messages
-- Validation: keep constructors/setters returning (T, error) for validation (e.g., SetDateTime)
-- Testing: table-driven tests where applicable; example_*.go for documentation tests; keep -race compatible when adding
-  tests
-
-## CI & Quality
-
-- Coverage report: reports/coverage.out (go tool cover -func)
-- Sonar/quality gate (optional): make sonar after test & lint
-
-## Cursor/Copilot Rules
-
-- No Cursor or Copilot rule files found; nothing to import at this time
+## Coding Style
+
+- Never add external third party libraries or package, we must use ONLY and exclusively the golang standard library
+- All type of tests, which can be unitest, fuzzy test, benchmark, or even race test, must be very atomic, targeting
+  individual cases, very atomic and simple.
+- Leverage and exten [shared/types/errors.go](shared/types/errors.go) to consolidate the message errors
+- No string should be longer than 40 charecters, no mather the reason.
+
+## Agent: Go Documentation Optimizer
+
+### Purpose
+
+Whenever I ask to “improve the documentation for a file,” this agent should automatically apply the following
+instructions. The goal is to ensure all Go files in the project have **pkgsite-ready documentation** with domain context (OCPP 1.6), making them clear, professional, and highly usable.
+
+Always write the file, if is possible
+
+### Universal Rules for Documentation
+
+- Always generate **pkgsite-style GoDoc comments** (top of file, package, and functions).
+- 80 columns limit of leght of the line
+- Documentation must be:
+  - Highly detailed
+  - Precise and professional
+  - Clear and idiomatic Go style
+- Always frame explanations in the context of **OCPP 1.6** (Open Charge Point Protocol v1.6).
+  - Explain why this type/test/function matters in OCPP.
+  - Highlight robustness, validation, and prevention of malformed/malicious input.
+  - Reference real OCPP 1.6 domains (transaction IDs, connector IDs, meter values, authorization IDs, etc.).
+- Include at least three levels of comments:
+  - Package-level comment — What this package/file is about and its role in OCPP.
+  - Type/function-level comments — What it does, valid/invalid behavior, expected usage.
+  - Contextual notes — Why this matters for OCPP 1.6 reliability, safety, and compliance.
+- Output should be ready to copy into the source file without extra formatting.
+- Do not just describe what the code does — connect it to why it matters in OCPP 1.6.
+
+### Prompt Template (auto-applied)
+
+```text
+Please improve and optimize the Go documentation for this file.  
+Follow the **Universal Rules for Documentation** in Agents.md.  
+
+**File:** <replace-with-path>
+```
+
+### Usage Notes
+
+- When I say:
+  > “Improve the documentation for @shared/types/fuzz/datetime_fuzz_test.go”
+  > The agent should automatically apply the rules above without me restating them.
+- Works for any file path.
+- Output must be directly usable in pkgsite.

README.md

@@ -5,8 +5,6 @@
 [![Coverage](https://sonarcloud.io/api/project_badges/measure?project=aasanchez_ocpp16_messages&metric=coverage)](https://sonarcloud.io/summary/new_code?id=aasanchez_ocpp16_messages)
 [![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=aasanchez_ocpp16_messages&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=aasanchez_ocpp16_messages)
 
----
-
 ## Overview
 
 This project provides a robust, modular, and thoroughly tested implementation of OCPP 1.6 message types and payload validation for Go. It is designed for high-quality message serialization, strict type safety, and OCPP-compliant EV charging station management.

golangci.yml

@@ -6,16 +6,20 @@ formatters:
     - gofumpt
     - goimports
     - golines
+    # - swaggo
 linters:
   default: all
   disable:
     - godot
-    - lll
-    - mnd
     - testpackage
-    - varnamelen
     - wsl
   settings:
+    wsl_v5:
+      allow-first-in-block: true
+      allow-whole-block: false
+      branch-max-lines: 2
+    lll:
+      line-length: 80
     revive:
       enable-all-rules: true
       rules:
@@ -26,7 +30,7 @@ linters:
           arguments:
             - ["ID"]
         - name: line-length-limit
-          disabled: true
+          arguments: [80]
         - name: add-constant
           disabled: true
         - name: exported
@@ -35,6 +39,8 @@ linters:
           disabled: true
         - name: cognitive-complexity
           arguments: [15]
+        - name: package-directory-mismatch
+          disabled: true
     depguard:
       rules:
         main:

messages/authorize/doc.go

@@ -0,0 +1 @@
+package authorize