Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I can't modify tuning #27

Open
Microbion opened this issue Nov 14, 2022 · 4 comments
Open

I can't modify tuning #27

Microbion opened this issue Nov 14, 2022 · 4 comments

Comments

@Microbion
Copy link

Thanks for tablature in new version. I can use TAB in obsidian. But TAB can't show when I modify the tuning parameter. Do I misunderstand the tuning parmater? I followed tablature totural. Here's my code:

{
  "tablature": [{"instrument": "guitar",
  "capo": 1,
  "label": "Guitar (%T)",
  "tuning": ["E", "A", "D", "G", "B", "e"]
 }]
}
---
X:1
T: Cooley's
M: 4/4
L: 1/8
R: reel
K: G
|:D2|EB{c}BA B2 EB|~B2 AB dBAG|FDAD BDAD|FDAD dAFD|

and TAB was lost without any warnings.
image
When I dropped tuning parameter, It worked as expected.

{
  "tablature": [{"instrument": "guitar",
  "capo": 1,
  "label": "Guitar (%T)"
 }]
}
---
X:1
T: Cooley's
M: 4/4
L: 1/8
R: reel
K: G
|:D2|EB{c}BA B2 EB|~B2 AB dBAG|FDAD BDAD|FDAD dAFD|

image
@alensiljak
Copy link
Collaborator

Thanks for the report. The plugin code is fairly simple and should just pass on all the parameters to abcjs.
I've tried with a simple HTML file:

<!DOCTYPE html>
<html>
<body>
    <div id="paper"></div>

    <script src="https://cdn.jsdelivr.net/npm/abcjs@6.1.6/dist/abcjs-basic-min.js"></script>

    <script>
        var options = {
            responsive: "resize",
            "tablature": [{"instrument": "guitar",
                "capo": 1,
                "label": "Guitar (%T)",
                "tuning": ["E", "A", "D", "G", "B", "e"]
            }]
        }

        let abcCode = "F c F c"

        ABCJS.renderAbc('paper', abcCode, options);
    </script>

</body>
</html>

and the same is happening.

Pinging @paulrosen.

@paulrosen
Copy link

Sorry for such a late response! I've been underwater here. There are two issues:

First, the lower notes are in the wrong octave and need a comma, so if you change it to the following it will work:

"tuning": ["E,", "A,", "D", "G", "B", "e"]

Second, clearly that case should have been handled. If you want to put light strings on the bottom of your guitar that's ok with me! I'll improve the error checking in the next version

@Microbion
Copy link
Author

Thank @alensiljak and @paulrosen. It's my misunderstanding, and now I get it.
I transform standard tuning to open D，and it works:
"tuning": ["D,", "A,", "D", "#F", "A", "d"]
image
I suggest to permit light strings on the bottom. In that way, I can record ukelele scores with violin style.

@Microbion
Copy link
Author

"tuning": ["D,", "A,", "D", "^F", "A", "d"] is suitful for open D tuning, right?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulrosen @alensiljak @Microbion