Skip to content

Commit 54932b4

Browse files
Upgrade Playwright to 1.39.0
This requires us to now explicitly install the browsers (see [1]). I’m doing this upgrade not because it’s necessary but because NPM tried to make it for me when resolving a package-lock.json merge conflict in an upcoming commit. Given that the upgrade involves this CI change, thought it best to do it as a separate commit so it doesn’t get lost inside a merge commit. [1] https://playwright.dev/docs/release-notes#breaking-changes-playwright-no-longer-downloads-browsers-automatically
1 parent b87ac65 commit 54932b4

File tree

3 files changed

+48
-22
lines changed

3 files changed

+48
-22
lines changed

.github/workflows/test-browser.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ jobs:
2525
with:
2626
node-version: 16.x
2727
- run: npm ci
28-
- name: Install playwright dependencies
29-
run: sudo npx playwright install-deps
28+
- name: Install Playwright browsers and dependencies
29+
run: npx playwright install --with-deps
3030
- env:
3131
PLAYWRIGHT_BROWSER: ${{ matrix.browser }}
3232
run: npm run test:playwright

package-lock.json

Lines changed: 45 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
"minimist": "^1.2.5",
8282
"mocha": "^8.1.3",
8383
"null-loader": "^4.0.1",
84-
"playwright": "^1.10.0",
84+
"playwright": "^1.39.0",
8585
"prettier": "^2.5.1",
8686
"react": ">=18.1.0",
8787
"react-dom": ">=18.1.0",

0 commit comments

Comments
 (0)