Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the signature of ProtocolMessage.serialize #1486

Open
lawrence-forooghian opened this issue Nov 6, 2023 · 1 comment
Open

Fix the signature of ProtocolMessage.serialize #1486

lawrence-forooghian opened this issue Nov 6, 2023 · 1 comment
Labels
code-quality Affects the developer experience when working in our codebase.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Nov 6, 2023

See description of #1480, in which I had to add a type assertion to get around the signature of serialize:

Fixing a newly-introduced compilation error calling wsConnection.send in WebSocketTransport (not sure exactly why, but I’m guessing something to do with the upgrade to the ws library in main and perhaps some changes to TypeScript version in v2) — the fix, which uses a type assertion to always pretend we’re always in the Node case, is a bit dodgy but that’s because the signature of ProtocolMessage.serialize is also a bit dodgy (it refers to Buffer even though the code that uses it is also called on web).

┆Issue is synchronized with this Jira Task by Unito

@lawrence-forooghian lawrence-forooghian added the code-quality Affects the developer experience when working in our codebase. label Nov 6, 2023
Copy link

sync-by-unito bot commented Nov 6, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Affects the developer experience when working in our codebase.
Development

No branches or pull requests

1 participant