Skip to content

Commit a4a2d52

Browse files
Fix the link to guidance on how to do Git commits
The linked Confluence page gives me a 404. Searching Confluence for "Git commit" gives me [1], which suggests that the canonical source for this data is actually the guidance that was added to this repo in ef8ac8f. [1] https://ably.atlassian.net/wiki/x/eoChEg
1 parent 33da110 commit a4a2d52

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

best-practices/pull-requests.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ In order for a PR to be merged, everyone who has been tagged as a reviewer must
3030

3131
## PR scope and structure
3232

33-
The scope and structure for a PR should be based on the guiding principles that apply to [commit and history structure](https://ably.atlassian.net/l/c/7QP1L31X): PRs should ideally cover a self-contained set of changes, with an overall scope that is large enough that the overall intent of the changes is clear, and small enough that it is manageable to be reviewed in detail. PRs that are too large tend to result in reviews that are more superficial and less effective.
33+
The scope and structure for a PR should be based on the guiding principles that apply to [commit and history structure](commits.md): PRs should ideally cover a self-contained set of changes, with an overall scope that is large enough that the overall intent of the changes is clear, and small enough that it is manageable to be reviewed in detail. PRs that are too large tend to result in reviews that are more superficial and less effective.
3434

3535
The use of branches generally should follow the policy for [development flow](https://ably.atlassian.net/wiki/spaces/PUB/pages/803766520). If the changes being made are necessarily extensive, then the preferred way to structure the work is as a series of PRs made against an integration branch, so each individual PR remains a manageable size.
3636

0 commit comments

Comments
 (0)