Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enhanced PurlDB "package set" lookup in d2d pipeline #829

Closed
pombredanne opened this issue Jul 27, 2023 · 3 comments
Closed

Use enhanced PurlDB "package set" lookup in d2d pipeline #829

pombredanne opened this issue Jul 27, 2023 · 3 comments
Assignees

Comments

@pombredanne
Copy link
Member

No description provided.

@JonoYang
Copy link
Member

@pombredanne

We would like some clarification about how we should be using package sets during the d2d process. Would this be a new step in the d2d pipeline where, after the purdb matching step, we request the enhanced package data for the packages that we matched to? Or would this be a new endpoint where we would be calling to get package data when we are in the matching process?

Tushar suggests that we should return the enhanced package data whenever we query for a package by sha1 from the packages endpoint to skip the extra API call.

@pombredanne
Copy link
Member Author

We would like some clarification about how we should be using package sets during the d2d process. Would this be a new step in the d2d pipeline where, after the purdb matching step, we request the enhanced package data for the packages that we matched to? Or would this be a new endpoint where we would be calling to get package data when we are in the matching process?

Tushar suggests that we should return the enhanced package data whenever we query for a package by sha1 from the packages endpoint to skip the extra API call.

I would likely see this as a single step, e.g., the standard end point to get data for a purl or to get a match and it would have an extra argument/option flag to return enhanced data. This would mean that in these cases that the "enhanced" query (likely an extra call) would done when required server-side.

An alternative could be to do it at a later stage at once for a bunch of packages, but the weird thing would be that we could have stored a package first with some data and later with enhanced data which seems a little odd.

@TG1999
Copy link
Contributor

TG1999 commented Aug 11, 2023

Done in aboutcode-org/purldb#157

@TG1999 TG1999 closed this as completed Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants