Fulfillment Inbound API v2024-03-20.

[IncredibleX]

Hi, i got the following mail. Is there anything planned?

---

We have deprecated 10 operations in Fulfillment Inbound API v0 with a removal date of December 20, 2024:

• createInboundShipmentPlan
• updateInboundShipment
• createInboundShipment
• getPreorderInfo
• confirmPreorder
• getTransportDetails
• putTransportDetails
• voidTransport
• estimateTransport
• confirmTransport

Thanx,

Tobias

[Cw733]

@abuzuhri @J-W-Chan @RenzoF

Can you guys give us any idea if you are able to review and merge pull requests, or is there some way we can help? Right now there is a PR #730 from @kevinvenclovas that addresses the the new Inbound Fulfillment, although it may not follow the same coding standards as the rest of the library, and has some additional changes outside of just the Inbound Fulfillment.

Is that something you guys can look at merging, or do you need help due to time? I'd like to see this project continue and I'd be willing to dedicate some time to it, but it doesn't make sense for several of us to implement the new APIs individually and then only one of them get merged into the original project.

Can you guys let us know your ideas about keeping the project up to date, and how we can help?

Thanks,
Casey

[abuzuhri]

Usually we merge fast but this branch so big and not same our sliced style and will need big time to review and I don’t have that time now . If you can help on adding new api but with same code style will be nice and will merge fast for you

…

On Tue, 9 Jul 2024 at 10:13 PM, Cw733 ***@***.***> wrote: @abuzuhri <https://github.com/abuzuhri> @J-W-Chan <https://github.com/J-W-Chan> @RenzoF <https://github.com/RenzoF> Can you guys give us any idea if you are able to review and merge pull requests, or is there some way we can help? Right now there is a PR #730 <#730> from @kevinvenclovas <https://github.com/kevinvenclovas> that addresses the the new Inbound Fulfillment, although it may not follow the same coding standards as the rest of the library, and has some additional changes outside of just the Inbound Fulfillment. Is that something you guys can look at merging, or do you need help due to time? I'd like to see this project continue and I'd be willing to dedicate some time to it, but it doesn't make sense for several of us to implement the new APIs and then only one of them get merged into the original project. Can you guys let us know your ideas about keeping the project up to date, and how we can help? Thanks, Casey — Reply to this email directly, view it on GitHub <#744 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4IEBBEGWTANXPKWK2UCGLZLQR6HAVCNFSM6AAAAABKBGJ2ZWVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAMBQGE2TGMA> . You are receiving this because you were mentioned.Message ID: <abuzuhri/Amazon-SP-API-CSharp/repo-discussions/744/comments/10001530@ github.com>

[Cw733]

Thanks Tareq, I thought that might be the case. I'll do my best to work on it as we will need it before the Dec. 30 2024 deadline.

Would you like a new namespace created that references the new API version, e.g. "FulfillmentInbound2024-03-20," and leave the original V0 version in place? This seems to be the pattern you guys have followed thus far, and I think it makes the most sense, but just want to make sure?

Thanks,
Casey

[kevinvenclovas]

Hey,

yes, I used the OpenAPI service to generate the API models. All other code follows the same coding style. Feel free to add the models directly to the project and remove the OpenAPI service.

[abuzuhri]

Also i notes that you remove old API , that not our standard work because maybe some one still usd the old API we don't want to damage his code after upgrade

[abuzuhri]

@kevinvenclovas is it possible to resubmit it without NSwagCSharp and with new keep old API ?

[kevinvenclovas]

@abuzuhri Check the new pull request :)

[Cw733]

Thanks @kevinvenclovas. If there is anything else I can do to help with this one let me know @abuzuhri. At first glance this new PR looks good to me.

[abuzuhri]

@kevinvenclovas Thanks for your work , please test v1.7.21 now and also add sample in readme file and add new sample file

[smargoli2]

Question about this: The new api does not support the getShipments endpoint where we can get shipments within a date range without shipment ids. This endpoint has not been deprecated as part of the migration, so we can potentially still use it. What do you recommend we do in this situation? Will this endpoint be deprecated eventually as well?