From 8df425e6da36cc1dc6815fb6aef2c269f92f815b Mon Sep 17 00:00:00 2001 From: Jason Judge Date: Fri, 15 Feb 2019 10:15:21 +0000 Subject: [PATCH] Return a 404 rather than a 500 if the oetition id is not valid. --- app/Http/Controllers/ReportController.php | 2 +- routes/web.php | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/Http/Controllers/ReportController.php b/app/Http/Controllers/ReportController.php index 0d2eeaf..31cb210 100644 --- a/app/Http/Controllers/ReportController.php +++ b/app/Http/Controllers/ReportController.php @@ -10,7 +10,7 @@ class ReportController extends Controller { - public function simpleOverview(int $petitionNumber = null) + public function simpleOverview($petitionNumber = null) { if ($petitionNumber !== null) { $petition = Petition::where('petition_number', '=', $petitionNumber) diff --git a/routes/web.php b/routes/web.php index 3d85d27..c03b7a2 100644 --- a/routes/web.php +++ b/routes/web.php @@ -11,11 +11,13 @@ | */ -Route::redirect('/', '/overview'); +Route::middleware('throttle:30,1')->group(function () { + // There is just the one page for now. -// ReportController + Route::redirect('/', '/overview'); + + // ReportController -Route::middleware('throttle:30,1')->group(function () { Route::get('/overview/{petitionNumber?}', 'ReportController@simpleOverview') ->name('overview'); });