Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden files within an available Section are appearing in Download list #29

Closed
dcombes opened this issue Aug 29, 2023 · 2 comments
Closed
Labels

Comments

@dcombes
Copy link

dcombes commented Aug 29, 2023

Our lecturers often hide some documents from students that are located within an available page Section. However, all the content of that Section, including these hidden files, are appearing in the Download Centre's list. It would be better, in line with the purpose of hidding content, if Download Centre is able to determine the hidden/visible status at the individual document level rather than at the page Section/Topic level, and so to not list hidden items that are located within available Sections.

This issue seems to have the same root cause (hidden status determined at page section level rather than individual document level) as the issue raised under "Files from available activities in hidden sections, available through stealth mode, are not included #20".

Thanks for your work on this, great plugin.
David

@goggo24
Copy link
Member

goggo24 commented Aug 31, 2023

Are you talking about hidden files in a available section? If yes, hidden files in available section can be downloaded only by teacher via download center. As a student the hidden file doesn't appear in the list - so the availability setting takes effect.

I just tried it with our newest version (v4.2.1 - 2023050501):
hiddenfile

Regarding #20: For students files "available but not shown on course page" are not listed too via download center. Only for teachers, because for this role the availability setting has no effect.

Or did you mean something else? If so, can you please give us a step-by-step description, so we can recreate it. Thanks, Eva.

@dcombes
Copy link
Author

dcombes commented Aug 31, 2023

Thanks Eva for confirming. Yes you are, of course, correct! Apologies, we were testing whilst in ‘teacher’ mode. This looks great and works well for us.
David

@dcombes dcombes closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants