From 9c1bc83c49472f294f999908c24ba301277bab4d Mon Sep 17 00:00:00 2001 From: John Gomez Date: Wed, 24 Jun 2015 23:01:55 -0400 Subject: [PATCH 1/2] Created comments where I think the modifications should happen --- .../github/mobile/accounts/AccountAuthenticator.java | 2 ++ .../mobile/accounts/AccountAuthenticatorService.java | 2 ++ .../java/com/github/mobile/core/gist/FullGist.java | 2 ++ .../github/mobile/persistence/AccountDataManager.java | 11 +++++++++++ .../com/github/mobile/ui/user/UserPagerAdapter.java | 6 ++++++ 5 files changed, 23 insertions(+) diff --git a/app/src/main/java/com/github/mobile/accounts/AccountAuthenticator.java b/app/src/main/java/com/github/mobile/accounts/AccountAuthenticator.java index b0b1ccc03..71a73800b 100644 --- a/app/src/main/java/com/github/mobile/accounts/AccountAuthenticator.java +++ b/app/src/main/java/com/github/mobile/accounts/AccountAuthenticator.java @@ -46,6 +46,8 @@ import org.eclipse.egit.github.core.Authorization; import org.eclipse.egit.github.core.service.OAuthService; +//I'm guessing this authenticates the account for the user. + public class AccountAuthenticator extends AbstractAccountAuthenticator { private static final String TAG = "GHAccountAuthenticator"; diff --git a/app/src/main/java/com/github/mobile/accounts/AccountAuthenticatorService.java b/app/src/main/java/com/github/mobile/accounts/AccountAuthenticatorService.java index 569aa62b9..b8c577785 100644 --- a/app/src/main/java/com/github/mobile/accounts/AccountAuthenticatorService.java +++ b/app/src/main/java/com/github/mobile/accounts/AccountAuthenticatorService.java @@ -38,4 +38,6 @@ private AccountAuthenticator getAuthenticator() { AUTHENTICATOR = new AccountAuthenticator(this); return AUTHENTICATOR; } + //I'm guessing this authenticates the account as well. I wish I didn't have to guess. Well + //on to the joyous feeling of discovery I travel. } \ No newline at end of file diff --git a/app/src/main/java/com/github/mobile/core/gist/FullGist.java b/app/src/main/java/com/github/mobile/core/gist/FullGist.java index c72af8888..7512b0684 100644 --- a/app/src/main/java/com/github/mobile/core/gist/FullGist.java +++ b/app/src/main/java/com/github/mobile/core/gist/FullGist.java @@ -22,6 +22,8 @@ import org.eclipse.egit.github.core.Comment; import org.eclipse.egit.github.core.Gist; + + /** * Gist model with comments and starred status */ diff --git a/app/src/main/java/com/github/mobile/persistence/AccountDataManager.java b/app/src/main/java/com/github/mobile/persistence/AccountDataManager.java index 2a2d383e2..3335c5787 100644 --- a/app/src/main/java/com/github/mobile/persistence/AccountDataManager.java +++ b/app/src/main/java/com/github/mobile/persistence/AccountDataManager.java @@ -49,6 +49,8 @@ */ public class AccountDataManager { + + private static final String TAG = "AccountDataManager"; private static final Executor EXECUTOR = Executors.newFixedThreadPool(10); @@ -194,6 +196,8 @@ public Collection getIssueFilters() { return Collections.emptyList(); } + + /** * Get bookmarked issue filters * @@ -304,4 +308,11 @@ protected void onException(Exception e) throws RuntimeException { } }.execute(); } + + /** + * I'm assuming this class would be a good place to put in the code + * that would also make the request to get and set the information for the user's profile + * settings. + **/ + } diff --git a/app/src/main/java/com/github/mobile/ui/user/UserPagerAdapter.java b/app/src/main/java/com/github/mobile/ui/user/UserPagerAdapter.java index c7a6a7eeb..37cdb30f8 100644 --- a/app/src/main/java/com/github/mobile/ui/user/UserPagerAdapter.java +++ b/app/src/main/java/com/github/mobile/ui/user/UserPagerAdapter.java @@ -75,4 +75,10 @@ public CharSequence getPageTitle(int position) { return null; } } + + /** + * In this class we would also tell he pager adapter to request + * the return of the 'settings' option. + * We might need to also create a fragment for the info. + */ } From 9f95abf5bd971d22ce36542fae961540174cc3a1 Mon Sep 17 00:00:00 2001 From: John Gomez Date: Wed, 24 Jun 2015 23:08:20 -0400 Subject: [PATCH 2/2] Removed redundancy --- .../java/com/github/mobile/accounts/AccountAuthenticator.java | 1 - .../com/github/mobile/accounts/AccountAuthenticatorService.java | 2 -- .../main/java/com/github/mobile/ui/user/UserPagerAdapter.java | 2 +- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/app/src/main/java/com/github/mobile/accounts/AccountAuthenticator.java b/app/src/main/java/com/github/mobile/accounts/AccountAuthenticator.java index 71a73800b..01f3431ef 100644 --- a/app/src/main/java/com/github/mobile/accounts/AccountAuthenticator.java +++ b/app/src/main/java/com/github/mobile/accounts/AccountAuthenticator.java @@ -46,7 +46,6 @@ import org.eclipse.egit.github.core.Authorization; import org.eclipse.egit.github.core.service.OAuthService; -//I'm guessing this authenticates the account for the user. public class AccountAuthenticator extends AbstractAccountAuthenticator { diff --git a/app/src/main/java/com/github/mobile/accounts/AccountAuthenticatorService.java b/app/src/main/java/com/github/mobile/accounts/AccountAuthenticatorService.java index b8c577785..569aa62b9 100644 --- a/app/src/main/java/com/github/mobile/accounts/AccountAuthenticatorService.java +++ b/app/src/main/java/com/github/mobile/accounts/AccountAuthenticatorService.java @@ -38,6 +38,4 @@ private AccountAuthenticator getAuthenticator() { AUTHENTICATOR = new AccountAuthenticator(this); return AUTHENTICATOR; } - //I'm guessing this authenticates the account as well. I wish I didn't have to guess. Well - //on to the joyous feeling of discovery I travel. } \ No newline at end of file diff --git a/app/src/main/java/com/github/mobile/ui/user/UserPagerAdapter.java b/app/src/main/java/com/github/mobile/ui/user/UserPagerAdapter.java index 37cdb30f8..ad0f16ebf 100644 --- a/app/src/main/java/com/github/mobile/ui/user/UserPagerAdapter.java +++ b/app/src/main/java/com/github/mobile/ui/user/UserPagerAdapter.java @@ -79,6 +79,6 @@ public CharSequence getPageTitle(int position) { /** * In this class we would also tell he pager adapter to request * the return of the 'settings' option. - * We might need to also create a fragment for the info. + * We might need to also create a fragment for the info. */ }