Skip to content

Commit 77ac300

Browse files
authored
Merge pull request #298 from acelaya/feature/update-js-coding-standard
Update to shlink JS coding standard v3.2.1
2 parents efbbe87 + 59a3240 commit 77ac300

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

.github/dependabot.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,12 @@ updates:
99
timezone: 'Europe/Madrid'
1010
open-pull-requests-limit: 10
1111
groups:
12-
eslint-plugins: # TODO Add eslint back once updated to v9
12+
eslint:
1313
patterns:
1414
- '@shlinkio/eslint-config-js-coding-standard'
1515
- 'typescript-eslint'
1616
- '*eslint-plugin*'
17+
- 'eslint'
1718
types:
1819
patterns:
1920
- '@types/*'

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"types": "tsc"
3838
},
3939
"devDependencies": {
40-
"@shlinkio/eslint-config-js-coding-standard": "~3.2.0",
40+
"@shlinkio/eslint-config-js-coding-standard": "~3.2.1",
4141
"@stylistic/eslint-plugin": "^2.9.0",
4242
"@testing-library/jest-dom": "^6.5.0",
4343
"@testing-library/react": "^16.0.1",

test/ExternalLink.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { ExternalLink } from '../src';
44

55
describe('<ExternalLink />', () => {
66
const setUp = (href = 'href', children?: ReactNode, rel?: string): ChildNode => {
7-
const { container } = render(<ExternalLink href={href} children={children} rel={rel} />);
7+
const { container } = render(<ExternalLink href={href} rel={rel}>{children}</ExternalLink>);
88
const { firstChild } = container;
99

1010
if (!firstChild) {

0 commit comments

Comments
 (0)