Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message to use subject_name #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix error message to use subject_name #25

wants to merge 3 commits into from

Conversation

minionOfZuul
Copy link
Contributor

The "schema name" returned by default_schema_record_name isn't helpful in identifying which subject can't be found. This PR updates the error message to use the subject name.

@acima-infosec-github-appsec
Copy link

Hi, I noticed this repo does not have all of the required topics applied to it. In order to organize repos at Acima, all repos need to have several topics that describe the nature of the repo. Please apply the topics as specified by the confluence article here: https://acima.atlassian.net/wiki/spaces/SEC/pages/313622545/Why+did+I+get+comments+on+my+PR

You are missing the following topics:

  • The data topic in the format of 'data-<data_type>
    Possible values are:
    data-non-prod
    data-prod-customer
    data-prod-systems
  • The type topic in the format of 'type-<data_type>
    Possible values are:
    type-service
    type-library
    type-sample
    type-other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aemadrid aemadrid aemadrid approved these changes

@matthewrampey matthewrampey Awaiting requested review from matthewrampey

Assignees
No one assigned
Labels
qa-required work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minionOfZuul @aemadrid @acimabot