-
Notifications
You must be signed in to change notification settings - Fork 348
Replace latexcodec with pylatexenc, using braces-all mode #4284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4284 +/- ##
==========================================
+ Coverage 92.54% 92.55% +0.01%
==========================================
Files 32 32
Lines 2294 2298 +4
==========================================
+ Hits 2123 2127 +4
Misses 171 171
|
Build successful. Some useful links:
This preview will be removed when the branch is merged. |
@danielgildea @nschneid I believe this fixes the issues with the BibTeX-encoding. Could you maybe have a look at the preview branch to spot-check if you see any issues with the way it encodes accents in BibTeX? |
How to check the preview? BibTeX isn't generated for previews right? |
It is generated for the first three papers of each volume. Those are also compiled in the anthology.bib.gz. |
Looks great, thank you! |
https://preview.aclanthology.org/fix-bibtex-encoding/2023.cl-2.3/ https://preview.aclanthology.org/fix-bibtex-encoding/2020.cl-3.3/ is a good test case. Also has |
—https://en.wikibooks.org/wiki/LaTeX/Special_Characters#Escaped_codes Interesting that pylatexenc produces this by default... |
Tried compiling a bibliography with |
I added conversion rules plus tests for í ì î ï to use the regular "i" instead of |
Great—and what about capitalized equivalents? |
Added to a test case now, which already passes. |
Cleaner duplicate of #4279 going directly into master, in order to see if this would address the current issues with the BibTeX encoding, see #4280.
This PR tests switching to pylatexenc for LaTeX-encoding strings, which is recommended by the latexcodec documentation and is also faster in my testing. I used the "braces-all" mode of pylatexenc, which should hopefully address #4280.