Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Puffin to 0.17; use puffin-egui in examples? #58

Closed
ids1024 opened this issue Nov 7, 2023 · 4 comments
Closed

Update Puffin to 0.17; use puffin-egui in examples? #58

ids1024 opened this issue Nov 7, 2023 · 4 comments

Comments

@ids1024
Copy link

ids1024 commented Nov 7, 2023

The latest version of Puffin is now 0.17.

The example uses puffin-imgui, which has been removed (EmbarkStudios/puffin#140) in favor of puffin-egui. So I guess the examples will need to be updated.

@aclysma
Copy link
Owner

aclysma commented Nov 12, 2023

Yeah, if you want a local build that just works, there's a decent chance you could just bump the version number and it would be fine. I just don't like publishing untested code, so I'd really prefer to update the examples first.

@aclysma
Copy link
Owner

aclysma commented Nov 27, 2023

I've rewritten the example to use eframe/egui in this branch https://github.com/aclysma/profiling/tree/new-puffin-example

If it passes CI I'll integrate. Latest version of puffin is now 0.18, I also updated to that version.

@ids1024
Copy link
Author

ids1024 commented Dec 4, 2023

Great! Once that's released, I'll be able to update pop-os/cosmic-comp#209.

@aclysma
Copy link
Owner

aclysma commented Dec 9, 2023

1.0.12 has been published

@aclysma aclysma closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants