Use correct passenger OSM tag to identify long distance routes

[claudiush]

It seems like you are looking at the wrong OSM tag for determining long distance routes. While the service=commuter tag is correct to determine local/commuter train routes, for other services the relevant OSM tag seems to be passenger with value "international", "national". Currently you are also looking for night trains in your SPARQL query, but they should be indicated by the secondary tag "by_night=yes" orthogonal to the passenger tagging, so that night train aspect can be dropped.

OSM wiki documentation
OSM wiki for train routes: https://wiki.openstreetmap.org/wiki/Key:passenger
OSM wiki for the "passenger=*" tag: https://wiki.openstreetmap.org/wiki/Key:passenger

Tag usage
Comparison of service=long_distance/high_speed (~1400 overall with ~1300 of them relations) and passenger=national/international (~3000 with 400 in relations): https://taginfo.openstreetmap.org/compare/service=long_distance/service=high_speed/passenger=national/passenger=international

Proposed change:
The "rail" query at https://github.com/ad-freiburg/global-transit-maps/blob/master/queries/rail.sparql should drop references of the "service" OSM tag and replace it instead with the documented passenger tag.
E.g. line 12:
Current {?rel osmkey:service "night"} UNION {?rel osmkey:service "national"} UNION {?rel osmkey:service "long_distance"} UNION {?rel osmkey:service "high_speed" } UNION {?rel osmkey:highspeed "yes" } .
Patched {?rel osmkey:passenger "international"} UNION {?rel osmkey:passenger "national"} UNION {?rel osmkey:highspeed "yes" } .

[claudiush]

I can see now that once again OSM wiki is conflicting itself in documentation. The "Public Transport" page is describing public transport routes with the service=* tag as it was initially commonplace ( https://wiki.openstreetmap.org/wiki/Public_transport#Service_routes ). It was discovered years ago already that the service=* tag means different things in regard of whether it was used on waterways, highways, railway tracks or even railway routes. See service tag wiki page: https://wiki.openstreetmap.org/wiki/Key:service#Train_Routes

That's why public transport tagging scheme updates introduced and is recommending the "passenger" tag instead on train routes. I would appreciate if the LOOM rendering would encourage use of the "better" tagging scheme using the passenger tag.