Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDEF NTAG215 and 216 compatability #55

Open
tgikal opened this issue Oct 1, 2018 · 3 comments
Open

NDEF NTAG215 and 216 compatability #55

tgikal opened this issue Oct 1, 2018 · 3 comments

Comments

@tgikal
Copy link

tgikal commented Oct 1, 2018

The nfc.ntag2xx_WriteNDEFURI(ndefprefix, url, dataLength) is written with dataLength defined as a uint8_t, which limits the data size to 256, even though NTAG215 and NTAG216 tags have much more memory than this.

A simple test of writing 450 x "a" will show it only writes 194 characters, which results from the 0x1C2 having being converted to 0xC2 by stuffing it in a uint8_t.

@tgikal
Copy link
Author

tgikal commented Oct 1, 2018

Managed to edit the .cpp and .h files to accommodate this issue.

The only other change made is making the "TIMEOUT!" message from waitready only print when debugging is turned on.

Please see https://github.com/adafruit/Adafruit-PN532/pull/56 for a fix.

@ladyada
Copy link
Member

ladyada commented Oct 1, 2018

hi @tgikal please stay positive and constructive in comments, we have 1000+ repos to maintain - not every issue & PR is handled immediately. please submit a PR if you have tested the code!

@caternuson
Copy link
Contributor

Looks like a dupe of #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants