Skip to content

Commit

Permalink
Merge pull request #211 from shubham0x13/main
Browse files Browse the repository at this point in the history
Allow empty text and update text instantly
  • Loading branch information
FoamyGuy authored Nov 10, 2024
2 parents 3ba5f74 + f237d6c commit b1eebc8
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions adafruit_display_text/scrolling_label.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def __init__(
self._last_animate_time = -1
self.max_characters = max_characters

if text[-1] != " ":
if text and text[-1] != " ":
text = "{} ".format(text)
self._full_text = text

Expand Down Expand Up @@ -123,10 +123,10 @@ def current_index(self) -> int:

@current_index.setter
def current_index(self, new_index: int) -> None:
if new_index < len(self.full_text):
self._current_index = new_index
else:
if self.full_text:
self._current_index = new_index % len(self.full_text)
else:
self._current_index = 0

@property
def full_text(self) -> str:
Expand All @@ -139,11 +139,12 @@ def full_text(self) -> str:

@full_text.setter
def full_text(self, new_text: str) -> None:
if new_text[-1] != " ":
if new_text and new_text[-1] != " ":
new_text = "{} ".format(new_text)
self._full_text = new_text
self.current_index = 0
self.update()
if new_text != self._full_text:
self._full_text = new_text
self.current_index = 0
self.update(True)

@property
def text(self):
Expand Down

0 comments on commit b1eebc8

Please sign in to comment.