Add suggested fix

makermelissa · makermelissa · commit 605dfc3f2b99 · 2024-04-01T13:10:56.000-07:00
diff --git a/src/NMEA_build.cpp b/src/NMEA_build.cpp
@@ -571,7 +571,8 @@ char *Adafruit_GPS::build(char *nmea, const char *thisSource,
     if (nmeaWithCRLF) {
       strcpy(nmeaWithCRLF, nmea);   // Copy original string
       strcat(nmeaWithCRLF, "\r\n"); // Append \r\n
-      return nmeaWithCRLF;          // return pointer to finished product
+      strcpy(nmea, nmeaWithCRLF);   // Copy back to original buffer
+      free(nmeaWithCRLF);           // Free the allocated memory
     }
   }
   return nmea; // return pointer to finished product

Original file line number	Diff line number	Diff line change
`@@ -571,7 +571,8 @@ char Adafruit_GPS::build(char nmea, const char *thisSource,`
`571`	`571`	`if (nmeaWithCRLF) {`
`572`	`572`	`strcpy(nmeaWithCRLF, nmea); // Copy original string`
`573`	`573`	`strcat(nmeaWithCRLF, "\r\n"); // Append \r\n`
`574`		`- return nmeaWithCRLF; // return pointer to finished product`
	`574`	`+ strcpy(nmea, nmeaWithCRLF); // Copy back to original buffer`
	`575`	`+ free(nmeaWithCRLF); // Free the allocated memory`
`575`	`576`	`}`
`576`	`577`	`}`
`577`	`578`	`return nmea; // return pointer to finished product`