Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity Adapter #566

Open
armin-zd opened this issue Jul 7, 2023 · 3 comments
Open

Identity Adapter #566

armin-zd opened this issue Jul 7, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@armin-zd
Copy link

armin-zd commented Jul 7, 2023

I am exploring a personalisation model that has one adapter per user. When there's enough data for a given user, an adapter is trained for that user, otherwise the default model weights are used (no adapters).

The problem is inference with Parallel. A batch contains samples from multiple users, some have adapters and some don't. However, it's not possible to extract default model weights with Parallel, eg. by using None adapter.

What is the best way to achieve this? I'm thinking of making a PR with an Identity Adapter.

Thanks!

@armin-zd armin-zd added the question Further information is requested label Jul 7, 2023
@adapter-hub-bert
Copy link
Member

This issue has been automatically marked as stale because it has been without activity for 90 days. This issue will be closed in 14 days unless you comment or remove the stale label.

@adapter-hub-bert
Copy link
Member

This issue was closed because it was stale for 14 days without any activity.

@adapter-hub-bert adapter-hub-bert closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2023
@calpt
Copy link
Member

calpt commented Nov 19, 2023

Sorry for not responding to this issue! Passing None for forward pass without adapters sounds like a sensible addition especially for Parallel and BatchSplit blocks (functionality would have to be added here).

Re-opening as feature requests. Open for PR, otherwise we'll look into it :)

@calpt calpt reopened this Nov 19, 2023
@calpt calpt added enhancement New feature or request and removed question Further information is requested Stale labels Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants