Skip to content

Commit 588f5aa

Browse files
committed
Explicitly mark all packages with commonjs type
See: https://nodejs.org/api/packages.html#packages_determining_module_system > Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted. Related issue: #2341
1 parent 31d99b3 commit 588f5aa

File tree

27 files changed

+38
-0
lines changed

27 files changed

+38
-0
lines changed

src/babel-plugin-transform-sx-tailwind/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "0.18.0",
88
"main": "./src/index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@adeira/murmur-hash": "^2.0.0",

src/babel-preset-adeira/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"license": "MIT",
77
"version": "3.0.0",
88
"main": "./src/index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@babel/plugin-proposal-class-properties": "^7.12.13",

src/css-colors/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"sideEffects": false,
77
"private": false,
88
"main": "./src/index.js",
9+
"type": "commonjs",
910
"license": "MIT",
1011
"dependencies": {
1112
"@adeira/js": "^2.1.0",

src/eslint-config-adeira/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "6.0.0",
88
"main": "./index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@babel/runtime": "^7.14.0",

src/eslint-fixtures-tester/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"homepage": "https://github.com/adeira/universe/tree/master/src/eslint-fixtures-tester",
55
"version": "0.1.0",
66
"main": "./src/index.js",
7+
"type": "commonjs",
78
"license": "MIT",
89
"private": false,
910
"dependencies": {

src/eslint-plugin-adeira/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "0.13.0",
88
"main": "./src/index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@babel/runtime": "^7.14.0",

src/eslint-plugin-sx/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"eslint-plugin"
1212
],
1313
"main": "./src/index.js",
14+
"type": "commonjs",
1415
"dependencies": {
1516
"@babel/runtime": "^7.14.0"
1617
},

src/fetch/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"license": "MIT",
55
"version": "2.1.0",
66
"main": "./src/fetchWithRetries.js",
7+
"type": "commonjs",
78
"sideEffects": false,
89
"homepage": "https://github.com/adeira/universe/tree/master/src/fetch",
910
"description": "Production ready fetch function with advanced capabilities like retries with delay and request cancellation after timeout.",

src/fixtures-tester/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "1.0.1",
88
"main": "./src/index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@adeira/js": "^2.1.0",

src/flow-config-parser/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"license": "MIT",
88
"main": "./src/index.js",
9+
"type": "commonjs",
910
"dependencies": {
1011
"@adeira/fixtures-tester": "^1.0.1",
1112
"@adeira/js": "^2.1.0",

src/flow-types-eslint/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"version": "0.0.0",
55
"private": true,
66
"main": "./src/index.js",
7+
"type": "commonjs",
78
"license": "MIT",
89
"dependencies": {}
910
}

src/graphql-bc-checker/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "0.3.0",
88
"main": "./src/index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@adeira/signed-source": "^2.0.0",

src/graphql-global-id/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "2.0.1",
88
"main": "./src/index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@adeira/js": "^2.1.0",

src/graphql-relay-fauna/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"private": false,
44
"version": "0.3.0",
55
"main": "./src/index.js",
6+
"type": "commonjs",
67
"sideEffects": false,
78
"homepage": "https://github.com/adeira/universe/tree/master/src/graphql-relay-fauna",
89
"description": "Helpers for Relay compliant GraphQL server with FaunaDB backend",

src/graphql-relay/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
"url": "http://github.com/adeira/universe.git"
1515
},
1616
"main": "./src/index.js",
17+
"type": "commonjs",
1718
"peerDependencies": {
1819
"graphql": "^15.0.0"
1920
},

src/graphql-resolve-wrapper/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "0.3.0",
88
"main": "./src/index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@babel/runtime": "^7.14.0"

src/js/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "2.1.0",
88
"main": "./src/index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@babel/runtime": "^7.14.0"

src/monorepo-npm-publisher/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "2.0.0",
88
"main": "./src/index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@adeira/babel-preset-adeira": "^3.0.0",

src/monorepo-scanner/src/scans/MainFields.scan.js renamed to src/monorepo-scanner/src/scans/PackageJson.scan.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,24 @@ Workspaces.iterateWorkspaces((packageJSONLocation) => {
99
test(`${packageJson.name}`, () => {
1010
const dirname = path.dirname(packageJSONLocation);
1111
const main = packageJson.main;
12+
const type = packageJson.type;
13+
1214
if (main != null) {
1315
const mainEntrypoint = path.join(dirname, main);
1416
// $FlowIssue[incompatible-call]: https://github.com/facebook/flow/issues/3018
1517
expect(fs.existsSync(mainEntrypoint)).toGiveHelp(
1618
`The file specified in main field does not exist (${mainEntrypoint}). If this is intentional, you can remove this field from package.json`,
1719
);
20+
21+
// $FlowIssue[incompatible-call]: https://github.com/facebook/flow/issues/3018
22+
expect(type != null).toGiveHelp(
23+
`Each package must specify "type" to be either "commonjs" or "module".`,
24+
);
25+
26+
// $FlowIssue[incompatible-call]: https://github.com/facebook/flow/issues/3018
27+
expect(['commonjs', 'module'].includes(type)).toGiveHelp(
28+
`Package type must be either "commonjs" or "module" (given "${type}").`,
29+
);
1830
}
1931
});
2032
});

src/monorepo-utils/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "0.11.0",
88
"main": "./src/index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"bin": {
1112
"monorepo-babel-node": "bin/monorepo-babel-node.js",

src/murmur-hash/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "2.0.0",
88
"main": "./src/murmurHash.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@babel/runtime": "^7.14.0"

src/relay/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"private": false,
44
"version": "3.2.4",
55
"main": "./src/index.js",
6+
"type": "commonjs",
67
"sideEffects": false,
78
"homepage": "https://github.com/adeira/universe/tree/master/src/relay",
89
"description": "Opinionated wrapper around Relay - a JavaScript framework for building data-driven React applications",

src/signed-source/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "2.0.0",
88
"main": "./src/SignedSource.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@babel/runtime": "^7.14.0"

src/sx-design/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "0.10.0",
88
"main": "./index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@adeira/js": "^2.1.0",

src/sx-jest-snapshot-serializer/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "0.1.0",
88
"main": "./index.js",
9+
"type": "commonjs",
910
"sideEffects": true,
1011
"dependencies": {
1112
"@adeira/sx": "^0.25.0",

src/sx-tailwind/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "0.12.0",
88
"main": "./index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@adeira/js": "^2.1.0",

src/sx/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"private": false,
77
"version": "0.25.0",
88
"main": "./index.js",
9+
"type": "commonjs",
910
"sideEffects": false,
1011
"dependencies": {
1112
"@adeira/css-colors": "^2.0.0",

0 commit comments

Comments
 (0)