Skip to content

Commit cf7e583

Browse files
committed
chore: replace deprecated Accompanist Test Harness with official DeviceConfigurationOverride
Docs: https://google.github.io/accompanist/testharness/
1 parent e4affe7 commit cf7e583

File tree

4 files changed

+17
-16
lines changed

4 files changed

+17
-16
lines changed

catalog/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ dependencies {
7171
implementation(libs.kotlin.reflect)
7272
implementation(libs.kotlinx.collections.immutable)
7373

74-
implementation(libs.accompanist.testharness)
7574
implementation(libs.accompanist.drawablepainter)
7675

7776
implementation(libs.androidx.compose.foundation)
7877
implementation(libs.androidx.compose.ui)
78+
implementation(libs.androidx.compose.ui.test)
7979
implementation(libs.androidx.compose.ui.tooling.preview)
8080
implementation(libs.androidx.compose.material.iconsExtended)
8181
implementation(libs.androidx.compose.material3)

catalog/src/main/kotlin/com/adevinta/spark/catalog/CatalogApp.kt

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,11 @@ import androidx.compose.ui.graphics.graphicsLayer
6262
import androidx.compose.ui.platform.LocalContext
6363
import androidx.compose.ui.platform.LocalDensity
6464
import androidx.compose.ui.platform.LocalLayoutDirection
65+
import androidx.compose.ui.test.DarkMode
66+
import androidx.compose.ui.test.DeviceConfigurationOverride
67+
import androidx.compose.ui.test.FontScale
68+
import androidx.compose.ui.test.LayoutDirection
69+
import androidx.compose.ui.test.then
6570
import androidx.compose.ui.unit.LayoutDirection
6671
import androidx.compose.ui.unit.dp
6772
import com.adevinta.spark.SparkFeatureFlag
@@ -74,7 +79,7 @@ import com.adevinta.spark.catalog.tabbar.CatalogTabBar
7479
import com.adevinta.spark.catalog.tabbar.CatalogTabs
7580
import com.adevinta.spark.catalog.themes.BrandMode
7681
import com.adevinta.spark.catalog.themes.ColorMode
77-
import com.adevinta.spark.catalog.themes.FontScaleMode
82+
import com.adevinta.spark.catalog.themes.FontScaleMode.System
7883
import com.adevinta.spark.catalog.themes.TextDirection
7984
import com.adevinta.spark.catalog.themes.Theme
8085
import com.adevinta.spark.catalog.themes.ThemeMode
@@ -92,7 +97,6 @@ import com.adevinta.spark.catalog.ui.rememberBackdropScaffoldState
9297
import com.adevinta.spark.catalog.ui.shaders.colorblindness.ColorBlindNessType
9398
import com.adevinta.spark.catalog.ui.shaders.colorblindness.shader
9499
import com.adevinta.spark.tokens.asSparkColors
95-
import com.google.accompanist.testharness.TestHarness
96100
import kotlinx.coroutines.launch
97101

98102
@Composable
@@ -171,15 +175,12 @@ internal fun ComponentActivity.CatalogApp(
171175
)
172176
}
173177

174-
@Suppress("DEPRECATION")
175-
TestHarness(
176-
darkMode = useDark,
177-
layoutDirection = layoutDirection,
178-
fontScale = if (theme.fontScaleMode == FontScaleMode.System) {
179-
LocalDensity.current.fontScale
180-
} else {
181-
theme.fontScale
182-
},
178+
DeviceConfigurationOverride(
179+
override = DeviceConfigurationOverride.DarkMode(useDark)
180+
then DeviceConfigurationOverride.LayoutDirection(layoutDirection)
181+
then DeviceConfigurationOverride.FontScale(
182+
theme.takeUnless { it.fontScaleMode == System }?.fontScale ?: LocalDensity.current.fontScale,
183+
),
183184
) {
184185
Box(
185186
modifier = Modifier

gradle/libs.versions.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ accompanist-flowlayout = { module = "com.google.accompanist:accompanist-flowlayo
3838
accompanist-pager = { module = "com.google.accompanist:accompanist-pager", version.ref = "accompanist" }
3939
accompanist-permissions = { module = "com.google.accompanist:accompanist-permissions", version.ref = "accompanist" }
4040
accompanist-swiperefresh = { module = "com.google.accompanist:accompanist-swiperefresh", version.ref = "accompanist" }
41-
accompanist-testharness = { module = "com.google.accompanist:accompanist-testharness", version.ref = "accompanist" }
4241

4342
androidx-activity = { module = "androidx.activity:activity-ktx", version.ref = "androidx-activity" }
4443
androidx-activity-compose = { module = "androidx.activity:activity-compose", version.ref = "androidx-activity" }
@@ -59,7 +58,8 @@ androidx-compose-ui = { module = "androidx.compose.ui:ui" }
5958
androidx-constraintlayout = { group = "androidx.constraintlayout", name = "constraintlayout", version.ref = "constraintlayout" }
6059
androidx-constraintlayoutCompose = { group = "androidx.constraintlayout", name = "constraintlayout-compose", version.ref = "constraintlayoutCompose" }
6160
androidx-compose-ui-text = { module = "androidx.compose.ui:ui-text-google-fonts" }
62-
androidx-compose-ui-test = { module = "androidx.compose.ui:ui-test-junit4" }
61+
androidx-compose-ui-test = { module = "androidx.compose.ui:ui-test" }
62+
androidx-compose-ui-testJUnit = { module = "androidx.compose.ui:ui-test-junit4" }
6363
androidx-compose-ui-testManifest = { module = "androidx.compose.ui:ui-test-manifest" }
6464
androidx-compose-ui-tooling = { module = "androidx.compose.ui:ui-tooling" }
6565
androidx-compose-ui-tooling-preview = { module = "androidx.compose.ui:ui-tooling-preview" }

spark/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,13 @@ dependencies {
8383
testImplementation(libs.androidx.test.runner)
8484
testImplementation(libs.testParameterInjector)
8585
testImplementation(libs.robolectric)
86-
testImplementation(libs.androidx.compose.ui.test)
86+
testImplementation(libs.androidx.compose.ui.testJUnit)
8787
testImplementation(libs.androidx.compose.ui.testManifest)
8888

8989
androidTestImplementation(libs.junit)
9090
androidTestImplementation(libs.kotlin.test)
9191
androidTestImplementation(libs.androidx.test.truth)
9292
androidTestImplementation(libs.androidx.test.runner)
93-
androidTestImplementation(libs.androidx.compose.ui.test)
93+
androidTestImplementation(libs.androidx.compose.ui.testJUnit)
9494
androidTestImplementation(libs.androidx.compose.ui.testManifest)
9595
}

0 commit comments

Comments
 (0)