Skip to content

Commit df7c97e

Browse files
authored
fix(paparazzi): detect untracked screenshots (#841)
1 parent 57fc4ef commit df7c97e

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

.github/actions/paparazzi-golden-images/action.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ runs:
2727
- run: ./gradlew recordPaparazziRelease
2828
shell: bash
2929
- run: |
30+
# Record all snapshots to the index, to be able to detect untracked ones
31+
git add --intent-to-add -- **/src/test/snapshots/**/*.png
3032
if ! git diff --quiet --exit-code -- **/src/test/snapshots/**/*.png ;
3133
then
3234
git config user.name 'spark-ui-bot'

spark-screenshot-testing/src/test/kotlin/com/adevinta/spark/textfields/TextFieldScreenshot.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ import com.adevinta.spark.patchedEnvironment
4040
import com.adevinta.spark.sparkSnapshot
4141
import com.android.ide.common.rendering.api.SessionParams
4242
import com.google.testing.junit.testparameterinjector.TestParameterInjector
43+
import org.junit.Ignore
4344
import org.junit.Rule
4445
import org.junit.Test
4546
import org.junit.runner.RunWith
@@ -66,6 +67,7 @@ internal class TextFieldScreenshot {
6667
)
6768

6869
@Test
70+
@Ignore("This needs to be re-worked to avoid generating 48 PNGs that are almost identical.")
6971
fun test() {
7072
values.forEach { value ->
7173
leadingIcons.forEach { leadingIcon ->

0 commit comments

Comments
 (0)