Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-108 New Playwright tests for the versions functionality. #130

Merged
merged 2 commits into from
May 17, 2024

Conversation

bosschaert
Copy link
Contributor

Description

Also updated the other Playwright test to not have to clean up their temporary files in a finally block any more (as that didn't work reliably), but rather clean these up together in a separate new 'delete' test that cleans up matching files if they are older than 2 hours. It does this cleanup through the UI so it also serves as a test for delete.

Related Issue

#108

How Has This Been Tested?

This PR is a test.

Types of changes

  • Just a test
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Also updated the other Playwright test to not have to clean up their
temporary files in a finally block any more, but rather clean these up
together in a separate 'delete' test that cleans up matching files if
they are older than 2 hours. It does this cleanup through the UI so it
also serves as a test for delete.
Copy link

aem-code-sync bot commented May 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@bosschaert bosschaert requested a review from auniverseaway May 16, 2024 16:14
@bosschaert bosschaert merged commit 9a30aeb into main May 17, 2024
4 of 5 checks passed
@bosschaert bosschaert deleted the versions-pw branch May 17, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants