Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Copy and Rename with Versioned document' playwright test #343

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

bosschaert
Copy link
Contributor

Description

This PR fixes a failing Playwright test which makes all Playwright tests pass on main.

Test URLs:

How Has This Been Tested?

This is a test.

Types of changes

Just a change to the Playwright test

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The page used during the test needs an extra reload to reset the state
of the page wrt to the versions displayed.
Copy link

aem-code-sync bot commented Feb 5, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Feb 5, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bosschaert
Copy link
Contributor Author

I left a TODO in the test to remind us that in theory we don't need this, but for now I think it's ok to call the extra reload().

@aem-code-sync aem-code-sync bot temporarily deployed to fvpwt February 6, 2025 13:04 Inactive
@bosschaert bosschaert merged commit ee4dc39 into main Feb 6, 2025
4 of 5 checks passed
@bosschaert bosschaert deleted the fvpwt branch February 6, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants