Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tiny changes to avoid the linter errors #344

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Some tiny changes to avoid the linter errors #344

merged 1 commit into from
Feb 6, 2025

Conversation

bosschaert
Copy link
Contributor

@bosschaert bosschaert commented Feb 6, 2025

Description

Just commented out some unused imports as they were causing the linter to fail. The code that uses these imports is still in the source (commented out too) so I thought to comment out the imports for now as well.

This fixes the lint execution and gets the build and test run to be green.

Test URLs:

Motivation and Context

To get a green 'Lint and Test' run.

How Has This Been Tested?

It is part of the testing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

aem-code-sync bot commented Feb 6, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Feb 6, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bosschaert bosschaert merged commit 8acad1c into main Feb 6, 2025
5 checks passed
@bosschaert bosschaert deleted the lintfx branch February 6, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants