Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-349 - Open in Universal Editor #350

Merged
merged 1 commit into from
Feb 21, 2025
Merged

GH-349 - Open in Universal Editor #350

merged 1 commit into from
Feb 21, 2025

Conversation

auniverseaway
Copy link
Member

  • Exposes quiet editor button for UE
  • Only shown if UE is configured for org.
  • Inteligently determines DX org name (@sitesinternal)
  • Gracefully handles hashchange / page to page navigation

Resolves: GH-349

Motivation and Context

How Has This Been Tested?

Unit & E2E

Screenshots (if appropriate):

Screenshot 2025-02-18 at 6 32 06 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* Exposes quiet editor button for UE
* Only shown if UE is configured for org.
* Inteligently determines DX org name (@sitesinternal)
* Gracefully handles hashchange / page to page navigation

Resolves: GH-349
Copy link

aem-code-sync bot commented Feb 19, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@auniverseaway auniverseaway merged commit 2f0ccc2 into main Feb 21, 2025
4 of 5 checks passed
@auniverseaway auniverseaway deleted the uelove branch February 21, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support open in Universal Editor
2 participants