GH-54 - Search & Replace #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chrischrischris
previously approved these changes
Mar 24, 2024
* Creates new search tab in browse view * Ability to search in current folder * Ability to replace found search term Resolves: GH-54
bosschaert
reviewed
Mar 25, 2024
| padding: 0 0 6px; | ||
| margin: 0; | ||
| box-sizing: border-box; | ||
| color: #8f8f8f; |
There was a problem hiding this comment.
Would it be an idea to start using variables for colors so we can easily change the color scheme going forward if we want to?
There was a problem hiding this comment.
Yes.
The idea is that if we know an official spectrum color, we elevate it to nexter and have an officially blessed variable.
This color in particular is a bit adhoc. We do not want a proliferation of variables for single one-off colors or colors we don't know will stick around.
bosschaert
approved these changes
Mar 25, 2024
|
Agreed. We have a lot of room for improvement with tests. da-browse is due for a refactor (it's too big) and will write tests with that. |
chrischrischris
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: GH-54
Motivation and Context
How Has This Been Tested?
https://search--da-live--adobe.hlx.live/#/adobecom/bacom
Screenshots (if appropriate):
Types of changes
Checklist:
Release notes
Resolves: GH-54