From 9562d993a875cc339114c22696bea9fc5ccd4f60 Mon Sep 17 00:00:00 2001 From: dylandepass Date: Mon, 7 Oct 2024 01:54:27 +0000 Subject: [PATCH] fix: flaky test (#117) --- .github/workflows/run-tests.yaml | 8 ++++++-- test/components/block-renderer/block-renderer.test.js | 5 ++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/run-tests.yaml b/.github/workflows/run-tests.yaml index 6522da2..d87bb36 100644 --- a/.github/workflows/run-tests.yaml +++ b/.github/workflows/run-tests.yaml @@ -19,6 +19,10 @@ jobs: env: CI: true - name: Upload coverage reports to Codecov - uses: codecov/codecov-action@v3 + uses: codecov/codecov-action@v4 + env: + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} with: - files: ./coverage/lcov.info \ No newline at end of file + fail_ci_if_error: true + files: ./coverage/lcov.info + verbose: true diff --git a/test/components/block-renderer/block-renderer.test.js b/test/components/block-renderer/block-renderer.test.js index a20cdda..3c91264 100644 --- a/test/components/block-renderer/block-renderer.test.js +++ b/test/components/block-renderer/block-renderer.test.js @@ -402,9 +402,7 @@ describe('BlockRenderer', () => { const img = cardsBlock.querySelector('img'); img.src = IMAGE; await aTimeout(1000); - const wrapper = blockRenderer.getBlockWrapper(); - const modifiedBlock = wrapper.querySelector('.cards'); - expect(modifiedBlock.querySelector('img').src).to.equal(IMAGE); + expect(cardsBlock.querySelector('img').src).to.equal(IMAGE); }); describe('enableImageDragDrop', () => { @@ -420,6 +418,7 @@ describe('BlockRenderer', () => { const cardsBlock = recursiveQuery(iframe.contentDocument, '.cards'); expect(cardsBlock).to.exist; + await aTimeout(1000); const img = cardsBlock.querySelector('img'); img.dispatchEvent(new Event('dragover', { target: img })); expect(img.style.outline).to.equal('rgb(84, 163, 246) solid 4px');