Skip to content

feat: accept readonly array for multiple select value #9221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: accept readonly array for multiple select value #9221

wants to merge 1 commit into from
+5 −4

Conversation

@lixiaoyan
Copy link
Contributor

@lixiaoyan lixiaoyan commented Nov 21, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

lixiaoyan
lixiaoyan commented Nov 24, 2025
View reviewed changes
packages/@react-types/select/src/index.d.ts
export type SelectionMode = 'single' | 'multiple';
export type ValueType<M extends SelectionMode> = M extends 'single' ? Key | null : Key[];
export type ValueType<M extends SelectionMode> = M extends 'single' ? Key | null : readonly Key[];
export type ChangeValueType<M extends SelectionMode> = M extends 'single' ? Key | null : Key[];
Copy link
Contributor Author

@lixiaoyan lixiaoyan Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we can remove the null from the change value type for single selection. We already have the disallowEmptySelection option set.

react-spectrum/packages/@react-stately/select/src/useSelectState.ts

Line 116 in 5d472d4

disallowEmptySelection: selectionMode === 'single',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lixiaoyan