POST Key Event - exception handler

[iustinp]

Description
Trying to create a new key event of a type other than the existing ones, will result in request timing out.

To Reproduce
E.g. Try adding a key of type: "type"

Expected behavior
Request should return an error.

[AndreiAlexandruParaschiv]

hey @iustinp, this shouldn't happen as there is a validation check for types in place here: https://github.com/adobe/spacecat-shared/blob/6bed3412af558946575f9f6be6d313ff0511db40/packages/spacecat-shared-data-access/src/models/key-event.js#L68-L70
In case a type is not in the KEY_EVENT_TYPES set, it will throw an error like below:

{
	"message": "Unknown value for \"type\": type"
}

The status code is 500 Internal Server error but it should a 400 - Bad Request as the type is incorrect.

[iustinp]

Hello! Indeed, i was able to see that the timeout-like behaviour is induced by Power Automate HTTP request action, because while the response from the spacecat API is instant (with the details you provided), the automation only fails after ~25minutes.
I will add extra checks on my side and also look to optimise the flow to throw such errors much faster.
In the meantime this probably can stay up for the wrong status code.
Thank you for looking into this!

[AndreiAlexandruParaschiv]

Updated the title for this ticket

The approach is to have an exceptionHandler (that extends the Error class) to throw the adequate error (400 for BadRequest)
Created the PR's

• feat: exceptionHandler spacecat-shared#276
• fix: exception handler key events #372

[AndreiAlexandruParaschiv]

@iuliag @ekremney Wdyt about this approach? ⬆️