Replies: 5 comments
-
|
I think we do struggle a lot overloading the term |
Beta Was this translation helpful? Give feedback.
-
|
I'm doing more work on this stuff, here's the pr for it. |
Beta Was this translation helpful? Give feedback.
-
|
The rename is done and I'm adding redirects for the static pages like https://opensource.adobe.com/spectrum-tokens/s2-tokens-viewer/ currently. |
Beta Was this translation helpful? Give feedback.
-
🚨 Breaking Changes Update - Need FeedbackThe repository rename is now complete in PR #632, but we've identified breaking changes that affect consumers of our published packages. We need confirmation that downstream consumers are aware and can accommodate these changes. What Changed1. JSON Schema All schema canonical identifiers changed from: to: 2. Internal Schema Changed from absolute URLs to relative paths:
Breaking Change ImpactAffected Packages:
Who is affected: Any external tools, validators, or schemas that reference our schemas by their What's NOT breaking:
|
Beta Was this translation helpful? Give feedback.
-
✅ Repository Rename CompleteDiscussion opened: June 20, 2024 What Was AccomplishedThe repository has been successfully renamed from Released Versions
What ChangedBreaking Changes:
Not Breaking:
Redirects ConfiguredThe following redirects are in place from the old
Verification
Related PRs
🎉 Closing this discussion as complete. Thanks to everyone who provided feedback! |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Problem statement
In this repository,
adobe/spectrum-tokens, we are adding more than just token data.Specifically, we are currently adding JSON schema for component options and have plans to add support for capturing component anatomy data in the future.
History
Historically, the token data and management tools were part of a repository named
spectrum-dna. It has been spectrum-tokens for a few years. We have since restructured the repository as a monorepo to manage several integrated packages, including token data manipulation tools. We are currently building a token diff report generating tool and moving the component options schema into their own package published on NPM.Proposal
Change the name from
adobe/spectrum-tokenstoadobe/spectrum-design-data.Alternatives considered
I considered changing it back to
spectrum-dnabecause I liked the name and historical context, but spectrum-design-data is the most descriptive of the purpose of the packages and data in this project.Consequences or Required Actions
Because I am not proposing changing the name of the @adobe/spectrum-tokens NPM package, most projects will not be impacted by this change.
It will impact the website for the token visualizer, but we could create a way to redirect to the new URL.
It will also impact the GitHub actions that keep the adobe/spectrum-tokens-studio-data repository in sync with this repository.
Beta Was this translation helpful? Give feedback.
All reactions