fix: command template

Author: thetutlage

commands/Make/Command.ts

@@ -8,6 +8,7 @@
 */
 
 import { join } from 'path'
+import snakeCase from 'snake-case'
 import { args } from '@adonisjs/ace'
 import { RcFile } from '@ioc:Adonis/Core/Application'
 import { BaseGenerator } from './Base'
@@ -52,6 +53,17 @@ export default class MakeCommand extends BaseGenerator {
     return rcFile.directories.commands || 'commands'
   }
 
+  /**
+   * Passed down to the template.
+   */
+  protected $templateData () {
+    return {
+      toCommandName: (filename: string) => {
+        return snakeCase(filename).replace(/_/, ':')
+      },
+    }
+  }
+
   public async handle () {
     this.$resourceName = this.name
     await super.handle()

package.json

@@ -100,6 +100,7 @@
     "fs-extra": "^8.1.0",
     "mem": "^6.0.0",
     "picomatch": "^2.1.1",
-    "slash": "^3.0.0"
+    "slash": "^3.0.0",
+    "snake-case": "^2.1.0"
   }
 }

templates/command.txt

@@ -1,7 +1,7 @@
 import { BaseCommand } from '@adonisjs/ace'
 
-export abstract class {filename} extends BaseCommand {
-  public static commandName = ''
+export default class ${filename} extends BaseCommand {
+  public static commandName = '${toCommandName(filename)}'
   public static description = ''
 
   public async handle () {

test/make-command.spec.ts

@@ -45,7 +45,11 @@ test.group('Make Command', (group) => {
     const CommandTemplate = await templates.get('command.txt')
     assert.deepEqual(
       toNewlineArray(GreetCommand),
-      toNewlineArray(CommandTemplate.replace('${filename}', 'Greet')),
+      toNewlineArray(
+        CommandTemplate
+          .replace('${filename}', 'Greet')
+          .replace('${toCommandName(filename)}', 'greet'),
+      ),
     )
   })
 
@@ -66,7 +70,36 @@ test.group('Make Command', (group) => {
     const CommandTemplate = await templates.get('command.txt')
     assert.deepEqual(
       toNewlineArray(GreetCommand),
-      toNewlineArray(CommandTemplate.replace('${filename}', 'Greet')),
+      toNewlineArray(
+        CommandTemplate
+          .replace('${filename}', 'Greet')
+          .replace('${toCommandName(filename)}', 'greet'),
+      ),
+    )
+  })
+
+  test('convert camelcase command path to colon seperated name', async (assert) => {
+    await fs.add('.adonisrc.json', JSON.stringify({
+      directories: {
+        commands: './foo',
+      },
+    }))
+
+    const app = new Application(fs.basePath, new Ioc(), {}, {})
+
+    const command = new MakeCommand(app)
+    command.name = 'RunInstructions'
+    await command.handle()
+
+    const GreetCommand = await fs.get('foo/RunInstructions.ts')
+    const CommandTemplate = await templates.get('command.txt')
+    assert.deepEqual(
+      toNewlineArray(GreetCommand),
+      toNewlineArray(
+        CommandTemplate
+          .replace('${filename}', 'RunInstructions')
+          .replace('${toCommandName(filename)}', 'run:instructions'),
+      ),
     )
   })
 })