Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs on Speaker Show Page don't wrap on mobile #404

Open
marcoroth opened this issue Nov 10, 2024 · 7 comments
Open

Tabs on Speaker Show Page don't wrap on mobile #404

marcoroth opened this issue Nov 10, 2024 · 7 comments
Labels
bug Something isn't working Frontend

Comments

@marcoroth
Copy link
Collaborator

Right now the tabs on the speaker show page don't wrap and thus let the whole page content overflow and expand because of it.

@marcoroth marcoroth added bug Something isn't working Frontend labels Nov 10, 2024
@marcoroth marcoroth changed the title Tabs on Speaker Show Page Show wrap on mobile Tabs on Speaker Show Page Show don't wrap on mobile Nov 10, 2024
@marcoroth marcoroth changed the title Tabs on Speaker Show Page Show don't wrap on mobile Tabs on Speaker Show Page don't wrap on mobile Nov 10, 2024
@adrienpoly
Copy link
Owner

In TailwindUI Tabs in mobile become select

IMG_9586

This other alternative is to make the tabs header scrollable

@marcoroth
Copy link
Collaborator Author

I'm surprised daisyUI doesn't handle it out of the box.

@nicogaldamez
Copy link
Contributor

@marcoroth, could you share a screenshot to help us understand the issue better? Which tabs are you referring to?

@marcoroth
Copy link
Collaborator Author

@nicogaldamez
Copy link
Contributor

Thanks, @marcoroth, that helps a lot!

Along with the TailwindUI select option, here are two more alternatives based on GitHub's UI approach.

  1. How about a list of collapsible items (accordion-style)? Imagine something like this, but instead of navigating to another page, it expands in place.
    image

  2. Using horizontally scrollable tabs. We may want to add a background to make it clear to users that they can scroll to see more
    image

@adrienpoly
Copy link
Owner

I like the collapsible option very much but in our case given the length of the transcript tab it might not be really suitable.

The select option from TailwindUI is the most responsive but I am not a big fan of the UX (open to change my mind)

I think scrollable tab would be a good candidate here

my 2 cents

@adrienpoly
Copy link
Owner

following to this change #413 the tabs do wrap now on mobile. Maybe not optimum but at least better than creating an overflow.

given also the changes in #423 at least now the talks#show page should not overflow anymore

We might still want to make here the tabs scrollable to prevent the wrap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Frontend
Projects
None yet
Development

No branches or pull requests

3 participants