Make it possible to move pictures within their frame #10
Comments
|
It does not seem easy to me to implement this. If you want to contribute, feel free! :-) |
|
Any chance that one of either Merge Request will be used/merged to get this feature someday in the near future? As for portait collages it would be pretty helpful to be able to move the attraction of the photo-part to the portraited face(s). |
|
@Blackskyliner thanks for the reminder! Let's follow this up in #46 |
…frame.
The Photo object has been updated with two extra properties: offset_w and offset_h which represent respectively the offset on the width and the offset on the height of a photo within their frame.
The offset value must be a number between 0 and 1:
- 0: means the photo is not cut on the left (top) but is fully cut on the right (bottom)
- 1: means the photo is not cut on the right (bottom) but is fully cut on the left
- 0.5: is the default value and means the photo is centered
- any other value betwen 0 and 1 will move the photo within the frame
A public move method has been added to move the photo within the cell.
ImagePreviewArea.SWAPPING has been renamed as SWAPPING_OR_MOVING because when clicking, moving the mouse and realising will trigger two different actions:
- SWAPPING: if the release of the button is done on another cell
- MOVING: if the release of the button is done on the same cell
The method ImagePreviewArea.button_release_event() has been accordingly modified.
The method RenderingTask.resize_photo() has been modified to take the offset in account.
|
Seems to me this issue could be closed, however the |
|
Thanks, I was wondering how to move photo inside a frame. this is the feature that I really need, thank you so much :) |
|
Which release is with this feature? I'm using Ubuntu 18.04 and I couldn't find. Even with the disco version It doesn't work. |
|
If I run photocollage normally this functionality does not work on my machine (Linux Mint 20.1 Cinnamon, python 3.8.10) but to my surprise, while trying to find out why, if I run it from vscode's terminal with "python3 -c 'from photocollage import gtkgui; gtkgui.main()'" (as mentioned in the "hacking" section) it just works. I can move the pictures within their frames as intended. Does anyone have an idea why? PS this is a nice piece of software, thank you for this. |
|
@FZill The answer may well be that you have two different versions installed: the packaged one by your distribution (most probably 1.4.4, the latest release) and the cloning of current working state of this repository. There have been some updates in-between. |
|
Ah you are absolutely right. I uninstalled the packaged version and installed the current working state and now everything is fine, thanks. |
|
Summary:
I suggest that we close this issue as completed and create a separate one to track "zooming images within frames". (Or we could change the issue title to include "zooming"). |
The program crops images to make them fit their "window" within the collage. I want to be able to move the picture within this window. This lets me fix things like cut-off heads.
Maybe it is possible to allow zooming, too.
The text was updated successfully, but these errors were encountered: