Skip to content

Commit 4610e58

Browse files
committed
Update:Home shelf labels use h2 tag, play & edit buttons overlaying item page updated to button tag with aria-label for accessibility #3699
1 parent 190a100 commit 4610e58

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

client/components/app/BookShelfCategorized.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<div v-else-if="isAlternativeBookshelfView" class="w-full mb-24e">
1818
<template v-for="(shelf, index) in supportedShelves">
1919
<widgets-item-slider :shelf-id="shelf.id" :key="index + '.'" :items="shelf.entities" :continue-listening-shelf="shelf.id === 'continue-listening' || shelf.id === 'continue-reading'" :type="shelf.type" class="bookshelf-row pl-8e my-6e" @selectEntity="(payload) => selectEntity(payload, index)">
20-
<p class="font-semibold text-gray-100">{{ $strings[shelf.labelStringKey] }}</p>
20+
<h2 class="font-semibold text-gray-100">{{ $strings[shelf.labelStringKey] }}</h2>
2121
</widgets-item-slider>
2222
</template>
2323
</div>

client/pages/item/_id/index.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
<!-- Item Cover Overlay -->
1313
<div class="absolute top-0 left-0 w-full h-full z-10 opacity-0 group-hover:opacity-100 pointer-events-none">
1414
<div v-show="showPlayButton && !isStreaming" class="h-full flex items-center justify-center pointer-events-none">
15-
<div class="hover:text-white text-gray-200 hover:scale-110 transform duration-200 pointer-events-auto cursor-pointer" @click.stop.prevent="playItem">
15+
<button class="hover:text-white text-gray-200 hover:scale-110 transform duration-200 pointer-events-auto cursor-pointer" :aria-label="$strings.ButtonPlay" @click.stop.prevent="playItem">
1616
<span class="material-symbols fill text-4xl">play_arrow</span>
17-
</div>
17+
</button>
1818
</div>
1919

20-
<span class="absolute bottom-2.5 right-2.5 z-10 material-symbols text-lg cursor-pointer text-white text-opacity-75 hover:text-opacity-100 hover:scale-110 transform duration-200 pointer-events-auto" @click="showEditCover">edit</span>
20+
<button class="absolute bottom-2.5 right-2.5 z-10 material-symbols text-lg cursor-pointer text-white text-opacity-75 hover:text-opacity-100 hover:scale-110 transform duration-200 pointer-events-auto" :aria-label="$strings.ButtonEdit" @click="showEditCover">edit</button>
2121
</div>
2222
</div>
2323
</div>
@@ -87,7 +87,7 @@
8787
</ui-btn>
8888

8989
<ui-btn v-else-if="isMissing || isInvalid" color="error" :padding-x="4" small class="flex items-center h-9 mr-2">
90-
<span v-show="!isStreaming" class="material-symbols text-2xl -ml-2 pr-1 text-white">error</span>
90+
<span class="material-symbols text-2xl -ml-2 pr-1 text-white">error</span>
9191
{{ isMissing ? $strings.LabelMissing : $strings.LabelIncomplete }}
9292
</ui-btn>
9393

0 commit comments

Comments
 (0)