Skip to content

Commit 5ee6005

Browse files
authored
Merge pull request #3914 from advplyr/progress_bar_visibility
Adds box shadow to progress bar on covers for visibility #3825
2 parents 1d57daa + 6a74698 commit 5ee6005

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

client/assets/app.css

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,10 @@
9292
}
9393

9494
/* Firefox */
95-
input[type=number] {
95+
input[type='number'] {
9696
-moz-appearance: textfield;
9797
}
9898

99-
10099
.tracksTable {
101100
border-collapse: collapse;
102101
width: 100%;
@@ -177,6 +176,10 @@ input[type=number] {
177176
box-shadow: 4px 1px 8px #11111166, -4px 1px 8px #11111166, 1px -4px 8px #11111166;
178177
}
179178

179+
.box-shadow-progressbar {
180+
box-shadow: 0px -1px 4px rgb(62, 50, 2, 0.5);
181+
}
182+
180183
.shadow-height {
181184
height: calc(100% - 4px);
182185
}
@@ -204,7 +207,6 @@ Bookshelf Label
204207
color: #fce3a6;
205208
}
206209

207-
208210
.cover-bg {
209211
width: calc(100% + 40px);
210212
height: calc(100% + 40px);

client/components/cards/LazyBookCard.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
</div>
4040

4141
<!-- No progress shown for podcasts (unless showing podcast episode) -->
42-
<div cy-id="progressBar" v-if="!isPodcast || episodeProgress" class="absolute bottom-0 left-0 h-1e shadow-sm max-w-full z-10 rounded-b" :class="itemIsFinished ? 'bg-success' : 'bg-yellow-400'" :style="{ width: coverWidth * userProgressPercent + 'px' }"></div>
42+
<div cy-id="progressBar" v-if="!isPodcast || episodeProgress" class="absolute bottom-0 left-0 h-1e max-w-full z-20 rounded-b box-shadow-progressbar" :class="itemIsFinished ? 'bg-success' : 'bg-yellow-400'" :style="{ width: coverWidth * userProgressPercent + 'px' }"></div>
4343

4444
<!-- Overlay is not shown if collapsing series in library -->
4545
<div cy-id="overlay" v-show="!booksInSeries && libraryItem && (isHovering || isSelectionMode || isMoreMenuOpen) && !processing" class="w-full h-full absolute top-0 left-0 z-10 bg-black rounded md:block" :class="overlayWrapperClasslist">

client/components/cards/LazySeriesCard.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<p :style="{ fontSize: 0.8 + 'em' }" role="status" :aria-label="$strings.LabelNumberOfBooks">{{ books.length }}</p>
1111
</div>
1212

13-
<div cy-id="seriesProgressBar" v-if="seriesPercentInProgress > 0" class="absolute bottom-0 left-0 h-1e shadow-sm max-w-full z-10 rounded-b w-full" :class="isSeriesFinished ? 'bg-success' : 'bg-yellow-400'" :style="{ width: seriesPercentInProgress * 100 + '%' }" />
13+
<div cy-id="seriesProgressBar" v-if="seriesPercentInProgress > 0" class="absolute bottom-0 left-0 h-1e shadow-sm max-w-full z-10 rounded-b w-full box-shadow-progressbar" :class="isSeriesFinished ? 'bg-success' : 'bg-yellow-400'" :style="{ width: seriesPercentInProgress * 100 + '%' }" />
1414

1515
<div cy-id="hoveringDisplayTitle" v-if="hasValidCovers" aria-hidden="true" class="bg-black bg-opacity-60 absolute top-0 left-0 w-full h-full flex items-center justify-center text-center transition-opacity" :class="isHovering ? '' : 'opacity-0'" :style="{ padding: '1em' }">
1616
<p :style="{ fontSize: 1.2 + 'em' }">{{ displayTitle }}</p>

0 commit comments

Comments
 (0)