Skip to content

Commit 232446c

Browse files
author
Simon Ramzi
committed
Fixed Typescript compiler issue from breaking change from 5.1.x to 5.2.x.
1 parent 6268381 commit 232446c

File tree

2 files changed

+30
-11
lines changed

2 files changed

+30
-11
lines changed

.github/workflows/publish-decision-spec-packages.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@ jobs:
4444
- id: db6068b8-f5ed-4968-847e-b642595243fd
4545
name: Install Typescript Compiler Globally
4646
run: |
47-
npm install --global typescript@5.x
47+
npm install --global typescript@5.2.x
4848
tsc --version
4949
5050
- id: e842d27d-141c-47f2-b64c-2c5702984edf
5151
name: Compile Package
5252
working-directory: ${{ env.WORKINGDIRECTORY_DECISION }}
5353
run: |
54-
tsc --outDir dist --declaration --target es5 --moduleResolution nodenext --lib es6,dom --showConfig *.ts
55-
tsc --outDir dist --declaration --target es5 --moduleResolution nodenext --lib es6,dom *.ts
54+
tsc --outDir dist --declaration --target es5 --module nodenext --moduleResolution nodenext --lib es6,dom --showConfig *.ts
55+
tsc --outDir dist --declaration --target es5 --module nodenext --moduleResolution nodenext --lib es6,dom *.ts
5656
5757
- id: edd89b5d-54fa-4951-8206-54b1cef91968
5858
name: Configure Project-Level .npmrc File

CHANGELOG.md

Lines changed: 27 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,24 +7,43 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
## [1.0.12] - 2023-08-29
11+
12+
### Fixed
13+
14+
- [sc-49448] Updated Typescript compiler options to fix [breaking change](https://devblogs.microsoft.com/typescript/announcing-typescript-5-2-rc/#module-and-moduleresolution-must-match-under-recent-node-js-settings) between `v5.1.x` to `v5.2.x`. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
15+
- [sc-49448] Removed unnecessary instances of `[sc-48140]` from `CHANGELOG.md`. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
16+
17+
### Changed
18+
19+
- [sc-49448] Fixed Typescript compiler version to `v5.2.x`. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
20+
21+
## [1.0.11] - 2023-08-29
22+
23+
### Added
24+
25+
- [sc-33985] Added an `includeArchived` option to the List Creative Templates endpoint for listing archived creative templates. By [@ryuichis](https://github.com/ryuichis).
26+
27+
## [1.0.10] - 2023-08-15
28+
1029
### Fixed
1130

1231
- [sc-48140] Targeting Javascript `ES5` instead of `ES6` for compatability. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
1332
- [sc-48140] Fixed clean script. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
1433

15-
## [1.0.9] - [sc-48140] 2023-08-15
34+
## [1.0.9] - 2023-08-15
1635

1736
### Nothing
1837

1938
- Problem with deploy due to GITHUB_REF_NAME, so republished. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
2039

21-
## [1.0.8] - [sc-48140] 2023-08-15
40+
## [1.0.8] - 2023-08-15
2241

2342
### Fixed
2443

2544
- [sc-48140] Added `npm publish` option `--access=public` to permit publish to public npm registry and not receive `You must sign up for private packages` due to scoped packages [being `restricted` by default](https://docs.npmjs.com/cli/v8/commands/npm-publish#access). By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
2645

27-
## [1.0.7] - [sc-48140] 2023-08-15
46+
## [1.0.7] - 2023-08-15
2847

2948
### Fixed
3049

@@ -41,25 +60,25 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
4160
- [sc-48140] Entries to `.gitignore` to assist testing of workflows. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
4261
- [sc-48140] Added work card ids to changelog for tracking. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
4362

44-
## [1.0.6] - [sc-48140] 2023-08-14
63+
## [1.0.6] - 2023-08-14
4564

4665
### Added
4766

4867
- [sc-48140] Debug statement to workflow. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
4968

50-
## [1.0.5] - [sc-48140] 2023-08-14
69+
## [1.0.5] - 2023-08-14
5170

5271
### Fixed
5372

5473
- [sc-48140] Typescript compiler error by fixing to version `5.x` on install. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
5574

56-
## [1.0.4] - [sc-48140] 2023-08-14
75+
## [1.0.4] - 2023-08-14
5776

5877
### Fixed
5978

6079
- [sc-48140] GitHub Actions working directory references `publish-decision-spec-packages.yml`. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
6180

62-
## [1.0.3] - [sc-48140] 2023-08-14
81+
## [1.0.3] - 2023-08-14
6382

6483
### Fixed
6584

@@ -69,7 +88,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
6988

7089
- [sc-48140] `package.json` file version to latest released. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
7190

72-
[1.0.2] - [sc-48140] 2023-08-14
91+
## [1.0.2] - 2023-08-14
7392

7493
### Changed
7594

0 commit comments

Comments
 (0)