Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBS incorrectly(?) lumps positive and negative effects together #102

Open
willw1 opened this issue Oct 5, 2021 · 0 comments
Open

NBS incorrectly(?) lumps positive and negative effects together #102

willw1 opened this issue Oct 5, 2021 · 0 comments

Comments

@willw1
Copy link

willw1 commented Oct 5, 2021

In the NBS implementation, when using the default 'both' for tails, the absolute value of the t test is used when thresholding prior to detecting cluster sizes. So an edge with a negative t score can appear to contribute to the 'size' of a cluster which also contains edges with positive t scores. Shouldn't the two conditions be treated separately, constructing one null distribution for positive t-score clusters, and another for negative ones? This would certainly make more sense if the cluster mass was used ('Fundamentals of Brain Network Analysis', Fornito et al., p407). Unfortunately, this does not appear to be discussed in the paper cited either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants