Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBS parallel #127

Open
daorse opened this issue Nov 30, 2023 · 0 comments
Open

NBS parallel #127

daorse opened this issue Nov 30, 2023 · 0 comments

Comments

@daorse
Copy link

daorse commented Nov 30, 2023

Hi, I think there are at least two big issues in NBS parallel. The first one is that the random generator is not used in a suitable way for multiprocessing. As a result it uses always the same permutation. In addition to this in the final line in the main function the p values are computed using null that is full of zeros. I think null_dist should be used instead.

Thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant