From 1863daaf696f88b3a67aee945ce5643b52354027 Mon Sep 17 00:00:00 2001 From: jingle chen <47862618+jinglechen2287@users.noreply.github.com> Date: Fri, 4 Apr 2025 21:05:41 -0400 Subject: [PATCH 1/2] fix hand tracking joint not having the correct world position --- src/components/hand-tracking-controls.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/components/hand-tracking-controls.js b/src/components/hand-tracking-controls.js index 81ba056b863..c3827640575 100644 --- a/src/components/hand-tracking-controls.js +++ b/src/components/hand-tracking-controls.js @@ -363,6 +363,7 @@ export var Component = registerComponent('hand-tracking-controls', { primitive: 'sphere', radius: 1.0 }); + jointEl.isJointDot = true; jointEl.object3D.visible = false; this.el.appendChild(jointEl); this.jointEls.push(jointEl); @@ -405,6 +406,7 @@ export var Component = registerComponent('hand-tracking-controls', { addChildEntity: function (childEl) { if (!(childEl instanceof AEntity)) { return; } + if (childEl.isJointDot) { return; } this.wristObject3D.add(childEl.object3D); } }); From 5db2bd2f50e1f9654b3a296837b786209d2d69b9 Mon Sep 17 00:00:00 2001 From: jingle chen <47862618+jinglechen2287@users.noreply.github.com> Date: Fri, 4 Apr 2025 21:12:19 -0400 Subject: [PATCH 2/2] refine variable name --- src/components/hand-tracking-controls.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/hand-tracking-controls.js b/src/components/hand-tracking-controls.js index c3827640575..bad994369ef 100644 --- a/src/components/hand-tracking-controls.js +++ b/src/components/hand-tracking-controls.js @@ -363,7 +363,7 @@ export var Component = registerComponent('hand-tracking-controls', { primitive: 'sphere', radius: 1.0 }); - jointEl.isJointDot = true; + jointEl.isHandJoint = true; jointEl.object3D.visible = false; this.el.appendChild(jointEl); this.jointEls.push(jointEl); @@ -406,7 +406,7 @@ export var Component = registerComponent('hand-tracking-controls', { addChildEntity: function (childEl) { if (!(childEl instanceof AEntity)) { return; } - if (childEl.isJointDot) { return; } + if (childEl.isHandJoint) { return; } this.wristObject3D.add(childEl.object3D); } });