Ceiling texture orientation doesn't match original game

[Allofich]

If you want to match the original game, the player's light radius should be 320 units. This is from examining the game code and it also appears to match when visually comparing.

Original game:

Current TESOpenArena:

TESOpenArena if you change
constexpr double PLAYER_LIGHT_END_RADIUS = 275.0 / MIFUtils::ARENA_UNITS;
in ArenaRenderUtils.h to
constexpr double PLAYER_LIGHT_END_RADIUS = 320.0 / MIFUtils::ARENA_UNITS;:

[Allofich]

Incidentally, I just noticed the ceiling textures appear to be different.

[afritz1]

Fixed the light radius.

START.INF doesn't have a *CEILING field in it. Maybe this value_or(1) in MapGeneration.cpp should be value_or(0).

	void writeVoxelInfoForCeiling(const INFFile &inf, ArenaVoxelType *outVoxelType, ArenaShapeInitCache *outShapeInitCache, TextureAsset *outTextureAsset)
	{
		constexpr ArenaVoxelType voxelType = ArenaVoxelType::Ceiling;
		*outVoxelType = voxelType;
		outShapeInitCache->initDefaultBoxValues(voxelType);

		// @todo: get ceiling from .INFs without *CEILING (like START.INF). Maybe hardcoding index 1 is enough?
		const INFCeiling &ceiling = inf.getCeiling();
		const int textureIndex = ceiling.textureIndex.value_or(1);

		const int clampedTextureID = ArenaVoxelUtils::clampVoxelTextureID(textureIndex);
		*outTextureAsset = TextureAsset(
			ArenaVoxelUtils::getVoxelTextureFilename(clampedTextureID, inf), 
			ArenaVoxelUtils::getVoxelTextureSetIndex(clampedTextureID, inf));
	} 

[Allofich]

START.INF doesn't have a *CEILING field in it. Maybe this value_or(1) in MapGeneration.cpp should be value_or(0).

I just tried it and the textures changed, but not to the ones the original game uses.

Actually that does set them to the same textures as the original game, but they are rotated and mirrored compared to it.

[Allofich]

Here is the original game texture again, with the compass removed to better see it.

Here it is in OpenTESArena with the change you suggested.

It's rotated 90 degrees and mirrored compared to the original. This seems to be the case for the ceilings of other dungeons, too.

[afritz1]

Yeah I'm pretty sure it's the same texture. I tried rotating the texture coordinates but it's a bit finicky with the mesh combining logic. The mesh is in data/meshes/CeilingBottom.obj. You have to make a source code change to get the build script to copy changed data files over, so just add a space in any .cpp file.

[Allofich]

What goes wrong when you try to rotate the texture coordinates? I don't know where or how to change the code locally to check myself.

[afritz1]

Depending on how the ceiling mesh combines, that section might be 1x3 or 2x2 or something, so rotating it just messes up the U and V tex coords so it looks squished. Just needs some fiddling probably.

Not at my PC but it's probably in the combined draw calls updating in RenderVoxelManager.