Skip to content
This repository was archived by the owner on Sep 23, 2024. It is now read-only.

Commit 1127248

Browse files
committed
SignTx not used arguments added back cause otherwise we arent compatible with the defined etherman interface
1 parent 7ad41e5 commit 1127248

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

etherman/etherman.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ func (e *Etherman) EstimateGas(ctx context.Context, from common.Address, to *com
147147
}
148148

149149
// SignTx tries to sign a transaction accordingly to the provided sender
150-
func (e *Etherman) SignTx(tx *types.Transaction) (*types.Transaction, error) {
150+
func (e *Etherman) SignTx(ctx context.Context, sender common.Address, tx *types.Transaction) (*types.Transaction, error) {
151151
return e.auth.Signer(e.auth.From, tx)
152152
}
153153

etherman/etherman_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,7 @@ func TestSignTx(t *testing.T) {
705705
ethClient := new(mocks.EthereumClientMock)
706706
ethman := getEtherman(ethClient)
707707

708-
transaction, err := ethman.SignTx(txData)
708+
transaction, err := ethman.SignTx(context.TODO(), common.Address{}, txData)
709709

710710
assert.Equal(transaction, txData)
711711
assert.Nil(err)

0 commit comments

Comments
 (0)