Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Improve validation of inputs #90

Open
NoxHarmonium opened this issue Aug 5, 2020 · 0 comments
Open

Improve validation of inputs #90

NoxHarmonium opened this issue Aug 5, 2020 · 0 comments
Labels
browser-extension Bugs to do with the browser extension enhancement New feature or request

Comments

@NoxHarmonium
Copy link
Contributor

I have added some // type-coverage:ignore-next-line comments in places where there is a force cast from a raw type to a specific type. This is OK at the moment since the inputs are known but is not very safe. We should probably use some sort of validation library like io-ts to avoid the force casting.
@NoxHarmonium NoxHarmonium added enhancement New feature or request browser-extension Bugs to do with the browser extension labels Aug 5, 2020
NoxHarmonium pushed a commit that referenced this issue Aug 5, 2020
chore: add exemptions for type-coverage
c68505c 
- In these cases we know what the source data is so it is OK for now but in the future we should add
some proper validation

re #90
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
browser-extension Bugs to do with the browser extension enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NoxHarmonium