Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Netlify Automated PR Review Instances/Environments #17

Open
ElijahLynn opened this issue Mar 12, 2020 · 1 comment
Open

Setup Netlify Automated PR Review Instances/Environments #17

ElijahLynn opened this issue Mar 12, 2020 · 1 comment
Assignees
@ElijahLynn
Labels
Infrastructure Environments, builds, deployments, etc

Comments

@ElijahLynn
Copy link
Contributor

ElijahLynn commented Mar 12, 2020 •
edited by bderfer68
Loading

As a developer I want to see and test my code changes before they get merged so that I can get feedback on them as rapidly as possible and avoid breaking the site.

https://www.netlify.com/blog/2016/07/20/introducing-deploy-previews-in-netlify/

AC:

  • Stakeholders can see and approve changes in context before they are deployed to production.
  • Technically: Full-site preview is posted as a link on the PR after pushing changes to my PR.
@bderfer68 bderfer68 added the Infrastructure Environments, builds, deployments, etc label Mar 18, 2020
@bderfer68 bderfer68 assigned bderfer68 and ElijahLynn and unassigned bderfer68 Mar 23, 2020
ElijahLynn pushed a commit that referenced this issue Mar 23, 2020
#17-test-PR-envs
5ddc8fa
@ElijahLynn
Copy link
Contributor Author

ElijahLynn commented Mar 23, 2020 •
edited
Loading

This is working now in #25, e.g. https://deploy-preview-25--agile6.netlify.com. All PRs will get a comment with a link to the new commit pushed to a PR. This was already happening on every PR but lacking the visibility with a comment.

image

image
#25 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElijahLynn ElijahLynn

Labels
Infrastructure Environments, builds, deployments, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ElijahLynn @bderfer68