-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFE] Pull quota-backend-bytes from etcd server? #40
Comments
Good point. I thought about it in the first place. But unfortunately, etcdserver doesn't export such an API to client for now. |
Ok, but maybe we can read prometheus metric for that? Maybe it will be necessary to set metrics http URL for that (as CLI arg or envvar?). We have much less variance in metric URLs (compared to variance of quotas) and pulling quota from metrics may be handy to dynamically adjust etcd-defrag work after quota increase, for example. Of course, such pull must be directly enabled to keep backward compability with current default quota in etcd-defrag. |
It's workaround instead of graceful solution to me. I suggest to keep it as it's for now until etcdserver exports an API to support this. |
FYI. etcd-io/etcd#17877 |
Will it be implemented any time soon? |
etcd-io/etcd#17877 has already been merged, but only in 3.6. |
Is it really necessary to set quota bytes as CLI arg? Can it be pulled from etcd server? Now we need to tune such CLI flag accordingly to every cluster, looks like bad work.
And thanks for really usefull tool!
The text was updated successfully, but these errors were encountered: