Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GHA M1 runners #429

Closed
danielhollas opened this issue Feb 4, 2024 · 7 comments
Closed

Migrate to GHA M1 runners #429

danielhollas opened this issue Feb 4, 2024 · 7 comments
Assignees

Comments

@danielhollas
Copy link
Contributor

Currently we use our own runners for the Arm build. GitHub recently made M1 runners available. Switching to them should hopefully significantly streamline our build.

I think this should be done first, and will hopefully make it easier to then remove the artifact-upload steps, as discussed in #414

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

See macos-14 runner.

@unkcpz
Copy link
Member

unkcpz commented Feb 5, 2024

Wow! This is fantastic, I checked 2 months ago and it cost quite a lot. Thanks for the update.

@danielhollas
Copy link
Contributor Author

I don't think this is relevant to us but just in case:
https://x.com/charliermarsh/status/1754542590517551258?s=20

@yakutovicha
Copy link
Member

Late to the party, but happy to see GitHub finally enabled the ARM runners. That can simplify the image build pipeline

@unkcpz
Copy link
Member

unkcpz commented Feb 23, 2024

Sadly, the runner is has some virtualization setting not support running docker inside yet https://github.com/douglascamata/setup-docker-macos-action?tab=readme-ov-file#arm64-processors-m1-m2-m3-series-used-on-macos-14-images-are-unsupported

@danielhollas
Copy link
Contributor Author

I am wondering, how does it work on the self-hosted runner? Is the runner running outside of Docker so it does not require nested virtualization?

@unkcpz
Copy link
Member

unkcpz commented Feb 27, 2024

From what I understand, the different between the self-hosted runner and the github runner is the github runner is already a virtulized machine. It not supported to have another virtualization layer inside it.
While for self-hosted machine, the machine itself is a physical machine and running docker through colima is just one layer virtulization.

@danielhollas
Copy link
Contributor Author

Looks like there isn't much we can do here for foreseeable future so I'll close this.
I subscribed to this issue in case something changes in the future douglascamata/setup-docker-macos-action#26
But it seems this would need changes from both Github (using >=M2 runners) and Apple (providing software support for nested virtualization). Too bad. :-(

@danielhollas danielhollas closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants