AEP: Testing toolchain for plugin packages #6
Conversation
instead of copying plugin folder to the docker container, mount it.
ltalirz
force-pushed
the
plugin_testing_toolchain
branch
from
8840c0f to
d14eb5c
Compare
yakutovicha
left a comment
yakutovicha
left a comment
There was a problem hiding this comment.
Please see my suggestions below.
| ``` | ||
| docker run -v .:/home/aiida/plugin aiida-cp2k-docker-stack -t test-container | ||
| docker exec --user aiida test-container pip install --user -e .[pre-commit,testing] | ||
| docker exec --user aiida test-container reentry scan |
There was a problem hiding this comment.
Suggestions:
- Put the whole content of
.travis.ymlhere. - Put the code above into
before_installsection of the.travis.ymlfile - Add an aiida version checker
There was a problem hiding this comment.
good idea. Let's do this one you have a working setup with aiida-cp2k
| docker run -v .:/home/aiida/plugin aiida-cp2k-docker-stack -t test-container | ||
| docker exec --user aiida test-container pip install --user -e .[pre-commit,testing] | ||
| docker exec --user aiida test-container reentry scan | ||
| docker exec --user aiida test-container py.test --cov aiida_cp2k --cov-append . |
There was a problem hiding this comment.
Don't forget that before running pytest one should wait a little bit before the container starts.
There was a problem hiding this comment.
I guess most of the time here is spent in creating the AiiDA profile, right?
When running tests via pytest, this is actually not needed.
Perhaps it would be a good idea to use an image for the tests that does not enforce the creation of a new profile?
There was a problem hiding this comment.
In the current setup, I don't think it is really possible. But I agree that we should modify the base docker image to allow this. Maybe by providing some variable CREATE_PROFILE_AT_STARTUP
thanks @yakutovicha Co-Authored-By: Aliaksandr Yakutovich <yakutovicha@gmail.com>
sphuber
changed the title
3 participants
submittedREADME.md