Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding get_size_on_remote to the Transport interface #6665

Open
GeigerJ2 opened this issue Dec 12, 2024 · 8 comments
Open

Adding get_size_on_remote to the Transport interface #6665

GeigerJ2 opened this issue Dec 12, 2024 · 8 comments
Labels
type/feature request status undecided

Comments

@GeigerJ2
Copy link
Contributor

As noted during discussions with the core office, @agoscinski, @khsrali, @unkcpz, on #6584:
It would be nice if the Transport could implement a method such as get_size or get_size_on_remote to which a path can be provided (as well as additional endpoints, if we think of more in the future).

In #6584, some custom logic to be added because FirecREST doesn't support arbitrary command execution and the aiida-firecrest transport/scheduler plugin therefore doesn't have an exec_command_wait method. However, this seems to be more a concern of the transport. As this change would require adding to the abstract interface of Transport, as well as implementing the methods it in its subclasses, just putting out the issue here as a reminder for the future for now.

@GeigerJ2 GeigerJ2 added the type/feature request status undecided label Dec 12, 2024
@khsrali
Copy link
Contributor

khsrali commented Dec 13, 2024

transport.du() 🥇

@unkcpz
Copy link
Member

unkcpz commented Jan 16, 2025

#6584 is merged, this one can be closed.

@unkcpz unkcpz closed this as completed Jan 16, 2025
@khsrali
Copy link
Contributor

khsrali commented Jan 16, 2025

@unkcpz I'm not sure that would close this issue,
I think this was mainly for future concerns and more like a feature request for transport plugins. @GeigerJ2 am I right?

@unkcpz
Copy link
Member

unkcpz commented Jan 16, 2025

Ah, right I didn't read the description carefully. reopen.

@unkcpz unkcpz reopened this Jan 16, 2025
@ayushjariyal
Copy link
Contributor

@GeigerJ2 Is this issue still open? If so, I would like to work on it.

@khsrali
Copy link
Contributor

khsrali commented Feb 19, 2025

@ayushjariyal This issue, is more for documenting reasons, and I don't think if there is a high priority to solve it.

It seems you are interested to solve something on transport plugins which you are making yourself familiar with.
Then perhaps maybe look into this instead:
#6751

@ayushjariyal
Copy link
Contributor

Thank you for the clarification. I will definitely try working on that issue.

@GeigerJ2
Copy link
Contributor Author

Thanks, @khsrali, for chipping in! Nothing to add here, this issue is just for keeping track of the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature request status undecided
Projects
None yet
Development

No branches or pull requests

4 participants